From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>,
Sean Anderson <sean.anderson@seco.com>,
x86@kernel.org
Subject: Re: [tip: timers/urgent] timekeeping: Use READ/WRITE_ONCE() for tick_do_timer_cpu
Date: Wed, 10 Apr 2024 16:54:34 +0200 [thread overview]
Message-ID: <87y19l2rpx.ffs@tglx> (raw)
In-Reply-To: <ZhZKiKyXsgSeABvD@gmail.com>
On Wed, Apr 10 2024 at 10:15, Ingo Molnar wrote:
>> @@ -232,7 +233,7 @@ static void tick_setup_device(struct tick_device *td,
>> !tick_nohz_full_cpu(cpu)) {
>> tick_take_do_timer_from_boot();
>> tick_do_timer_boot_cpu = -1;
>> - WARN_ON(tick_do_timer_cpu != cpu);
>> + WARN_ON(READ_ON_ONCE(tick_do_timer_cpu) != cpu);
>
> So there's no such thing as READ_ON_ONCE() - I've amended the commit with
> the fix below.
Can you hand me a brown paper bag please?
next prev parent reply other threads:[~2024-04-10 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 19:32 [BUG] KCSAN: data-race in tick_nohz_idle_stop_tick / tick_nohz_next_event Mirsad Todorovac
2023-08-18 14:15 ` Mirsad Todorovac
2024-03-07 19:43 ` Sean Anderson
2024-03-09 16:13 ` Mirsad Todorovac
2024-03-11 14:48 ` Thomas Gleixner
2024-03-11 16:30 ` Sean Anderson
2024-04-09 10:29 ` timekeeping: Use READ/WRITE_ONCE() for tick_do_timer_cpu Thomas Gleixner
2024-04-09 21:18 ` [tip: timers/urgent] " tip-bot2 for Thomas Gleixner
2024-04-10 8:15 ` Ingo Molnar
2024-04-10 14:54 ` Thomas Gleixner [this message]
2024-04-10 8:22 ` tip-bot2 for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y19l2rpx.ffs@tglx \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=sean.anderson@seco.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox