From: Takashi Iwai <tiwai@suse.de>
To: Christian@bendiksen.me
Cc: james.schulman@cirrus.com, david.rhodes@cirrus.com,
rf@opensource.cirrus.com, perex@perex.cz, tiwai@suse.com,
sbinding@opensource.cirrus.com, kailang@realtek.com,
luke@ljones.dev, shenghao-ding@ti.com, foss@athaariq.my.id,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christian Bendiksen <christian@bendiksen.me>
Subject: Re: [PATCH v2] Add sound quirks for Lenovo Legion slim 7 16ARHA7 models.
Date: Mon, 01 Apr 2024 10:17:11 +0200 [thread overview]
Message-ID: <87y19x5wfs.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240330115554.27895-1-christian@bendiksen.me>
On Sat, 30 Mar 2024 12:56:09 +0100,
Christian@bendiksen.me wrote:
>
> From: Christian Bendiksen <christian@bendiksen.me>
>
> This fixes the sound not working from internal speakers on
> Lenovo Legion Slim 7 16ARHA7 models. The correct subsystem ID
> have been added to cs35l41_hda_property.c and patch_realtek.c.
>
> Signed-off-by: Christian Bendiksen <christian@bendiksen.me>
> ---
> sound/pci/hda/cs35l41_hda_property.c | 4 ++++
> sound/pci/hda/patch_realtek.c | 2 ++
> 2 files changed, 6 insertions(+)
>
> diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
> index 72ec872afb8d..d6ea3ab72f75 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -109,6 +109,8 @@ static const struct cs35l41_config cs35l41_config_table[] = {
> { "10431F1F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },
> { "10431F62", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
> { "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
> + { "17AA3877", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
> + { "17AA3878", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
> { "17AA38A9", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
> { "17AA38AB", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
> { "17AA38B4", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
> @@ -497,6 +499,8 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
> { "CSC3551", "10431F1F", generic_dsd_config },
> { "CSC3551", "10431F62", generic_dsd_config },
> { "CSC3551", "17AA386F", generic_dsd_config },
> + { "CSC3551", "17AA3877", generic_dsd_config },
> + { "CSC3551", "17AA3878", generic_dsd_config },
> { "CSC3551", "17AA38A9", generic_dsd_config },
> { "CSC3551", "17AA38AB", generic_dsd_config },
> { "CSC3551", "17AA38B4", generic_dsd_config },
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index a17c36a36aa5..0fb2d23b3d35 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10333,6 +10333,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x17aa, 0x3869, "Lenovo Yoga7 14IAL7", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
> SND_PCI_QUIRK(0x17aa, 0x386f, "Legion 7i 16IAX7", ALC287_FIXUP_CS35L41_I2C_2),
> SND_PCI_QUIRK(0x17aa, 0x3870, "Lenovo Yoga 7 14ARB7", ALC287_FIXUP_YOGA7_14ARB7_I2C),
> + SND_PCI_QUIRK(0x17aa, 0x3877, "Lenovo Legion 7 Slim 16ARHA7", ALC287_FIXUP_CS35L41_I2C_2"),
> + SND_PCI_QUIRK(0x17aa, 0x3878, "Lenovo Legion 7 Slim 16ARHA7", ALC287_FIXUP_CS35L41_I2C_2"),
Those break the builds obviously.
*PLEASE* verify the compilation before submitting your patches.
thanks,
Takashi
next prev parent reply other threads:[~2024-04-01 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 18:54 [PATCH] Add sound quirks for Lenovo Legion slim 7 16ARHA7 models Christian
2024-03-30 8:35 ` Takashi Iwai
2024-03-30 11:56 ` [PATCH v2] " Christian
2024-04-01 8:17 ` Takashi Iwai [this message]
2024-04-01 12:26 ` [PATCH v3] " Christian Bendiksen
2024-04-02 6:01 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y19x5wfs.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Christian@bendiksen.me \
--cc=alsa-devel@alsa-project.org \
--cc=david.rhodes@cirrus.com \
--cc=foss@athaariq.my.id \
--cc=james.schulman@cirrus.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox