* [PATCH 1/5] staging: rtl8192e: renamed variable bCurShortGI40MHz
2023-12-08 1:55 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
@ 2023-12-08 1:55 ` Gary Rookard
2023-12-08 1:55 ` [PATCH 2/5] staging: rtl8192e: renamed variable bCurShortGI20MHz Gary Rookard
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Gary Rookard @ 2023-12-08 1:55 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. bCurShortGI40MHz -> cur_short_gi_40mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++---
drivers/staging/rtl8192e/rtllib_tx.c | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 39fa5f60db45..f01240f7e514 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1763,7 +1763,7 @@ void rtl92e_update_ratr_table(struct net_device *dev)
}
ratr_value &= 0x0FFFFFFF;
if (ieee->ht_info->cur_tx_bw40mhz &&
- ieee->ht_info->bCurShortGI40MHz)
+ ieee->ht_info->cur_short_gi_40mhz)
ratr_value |= 0x80000000;
else if (!ieee->ht_info->cur_tx_bw40mhz &&
ieee->ht_info->bCurShortGI20MHz)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index 330dafd62656..c73d2ac910d5 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -287,7 +287,7 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev)
if (priv->rtllib->link_state == MAC80211_LINKED) {
bshort_gi_enabled = (ht_info->cur_tx_bw40mhz &&
- ht_info->bCurShortGI40MHz) ||
+ ht_info->cur_short_gi_40mhz) ||
(!ht_info->cur_tx_bw40mhz &&
ht_info->bCurShortGI20MHz);
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index 98c1e5840e31..f89b618f71a5 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -97,7 +97,7 @@ struct rt_hi_throughput {
u8 reg_bw_40mhz;
u8 cur_bw_40mhz;
u8 reg_short_gi_40mhz;
- u8 bCurShortGI40MHz;
+ u8 cur_short_gi_40mhz;
u8 reg_short_gi_20mhz;
u8 bCurShortGI20MHz;
u8 reg_supp_cck;
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index a421c56af9e2..f9c76aaf8791 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -109,7 +109,7 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 mcs_rate)
u8 is40MHz = (ht_info->cur_bw_40mhz) ? 1 : 0;
u8 isShortGI = (ht_info->cur_bw_40mhz) ?
- ((ht_info->bCurShortGI40MHz) ? 1 : 0) :
+ ((ht_info->cur_short_gi_40mhz) ? 1 : 0) :
((ht_info->bCurShortGI20MHz) ? 1 : 0);
return MCS_DATA_RATE[is40MHz][isShortGI][(mcs_rate & 0x7f)];
}
@@ -481,7 +481,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
ht_info->bCurShortGI20MHz = ((ht_info->reg_short_gi_20mhz) ?
((pPeerHTCap->ShortGI20Mhz == 1) ?
true : false) : false);
- ht_info->bCurShortGI40MHz = ((ht_info->reg_short_gi_40mhz) ?
+ ht_info->cur_short_gi_40mhz = ((ht_info->reg_short_gi_40mhz) ?
((pPeerHTCap->ShortGI40Mhz == 1) ?
true : false) : false);
@@ -563,7 +563,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
ht_info->cur_tx_bw40mhz = false;
ht_info->bCurShortGI20MHz = false;
- ht_info->bCurShortGI40MHz = false;
+ ht_info->cur_short_gi_40mhz = false;
ht_info->forced_short_gi = false;
ht_info->bCurSuppCCK = true;
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index e2dd2772bbeb..041520e6c28d 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -362,7 +362,7 @@ static void rtllib_query_HTCapShortGI(struct rtllib_device *ieee,
return;
}
- if (ht_info->cur_bw_40mhz && ht_info->bCurShortGI40MHz)
+ if (ht_info->cur_bw_40mhz && ht_info->cur_short_gi_40mhz)
tcb_desc->bUseShortGI = true;
else if (!ht_info->cur_bw_40mhz && ht_info->bCurShortGI20MHz)
tcb_desc->bUseShortGI = true;
--
2.41.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/5] staging: rtl8192e: renamed variable bCurShortGI20MHz
2023-12-08 1:55 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
2023-12-08 1:55 ` [PATCH 1/5] staging: rtl8192e: renamed variable bCurShortGI40MHz Gary Rookard
@ 2023-12-08 1:55 ` Gary Rookard
2023-12-08 1:55 ` [PATCH 3/5] staging: rtl8192e: renamed variable CCKOFDMRate Gary Rookard
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Gary Rookard @ 2023-12-08 1:55 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. bCurShortGI20MHz -> cur_short_gi_20mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++---
drivers/staging/rtl8192e/rtllib_tx.c | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index f01240f7e514..e6d51abd0d01 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1766,7 +1766,7 @@ void rtl92e_update_ratr_table(struct net_device *dev)
ieee->ht_info->cur_short_gi_40mhz)
ratr_value |= 0x80000000;
else if (!ieee->ht_info->cur_tx_bw40mhz &&
- ieee->ht_info->bCurShortGI20MHz)
+ ieee->ht_info->cur_short_gi_20mhz)
ratr_value |= 0x80000000;
rtl92e_writel(dev, RATR0 + rate_index * 4, ratr_value);
rtl92e_writeb(dev, UFWP, 1);
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index c73d2ac910d5..e2828d57d1fd 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -289,7 +289,7 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev)
bshort_gi_enabled = (ht_info->cur_tx_bw40mhz &&
ht_info->cur_short_gi_40mhz) ||
(!ht_info->cur_tx_bw40mhz &&
- ht_info->bCurShortGI20MHz);
+ ht_info->cur_short_gi_20mhz);
pra->upper_rssi_threshold_ratr =
(pra->upper_rssi_threshold_ratr & (~BIT(31))) |
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index f89b618f71a5..77f28d87d3c0 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -99,7 +99,7 @@ struct rt_hi_throughput {
u8 reg_short_gi_40mhz;
u8 cur_short_gi_40mhz;
u8 reg_short_gi_20mhz;
- u8 bCurShortGI20MHz;
+ u8 cur_short_gi_20mhz;
u8 reg_supp_cck;
u8 bCurSuppCCK;
enum ht_spec_ver ePeerHTSpecVer;
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index f9c76aaf8791..633f735bdab1 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -110,7 +110,7 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 mcs_rate)
u8 is40MHz = (ht_info->cur_bw_40mhz) ? 1 : 0;
u8 isShortGI = (ht_info->cur_bw_40mhz) ?
((ht_info->cur_short_gi_40mhz) ? 1 : 0) :
- ((ht_info->bCurShortGI20MHz) ? 1 : 0);
+ ((ht_info->cur_short_gi_20mhz) ? 1 : 0);
return MCS_DATA_RATE[is40MHz][isShortGI][(mcs_rate & 0x7f)];
}
@@ -478,7 +478,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
ht_info->cur_tx_bw40mhz = ((pPeerHTInfo->RecommemdedTxWidth == 1) ?
true : false);
- ht_info->bCurShortGI20MHz = ((ht_info->reg_short_gi_20mhz) ?
+ ht_info->cur_short_gi_20mhz = ((ht_info->reg_short_gi_20mhz) ?
((pPeerHTCap->ShortGI20Mhz == 1) ?
true : false) : false);
ht_info->cur_short_gi_40mhz = ((ht_info->reg_short_gi_40mhz) ?
@@ -562,7 +562,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
ht_info->cur_bw_40mhz = false;
ht_info->cur_tx_bw40mhz = false;
- ht_info->bCurShortGI20MHz = false;
+ ht_info->cur_short_gi_20mhz = false;
ht_info->cur_short_gi_40mhz = false;
ht_info->forced_short_gi = false;
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index 041520e6c28d..ed264fc75457 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -364,7 +364,7 @@ static void rtllib_query_HTCapShortGI(struct rtllib_device *ieee,
if (ht_info->cur_bw_40mhz && ht_info->cur_short_gi_40mhz)
tcb_desc->bUseShortGI = true;
- else if (!ht_info->cur_bw_40mhz && ht_info->bCurShortGI20MHz)
+ else if (!ht_info->cur_bw_40mhz && ht_info->cur_short_gi_20mhz)
tcb_desc->bUseShortGI = true;
}
--
2.41.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/5] staging: rtl8192e: renamed variable CCKOFDMRate
2023-12-08 1:55 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
2023-12-08 1:55 ` [PATCH 1/5] staging: rtl8192e: renamed variable bCurShortGI40MHz Gary Rookard
2023-12-08 1:55 ` [PATCH 2/5] staging: rtl8192e: renamed variable bCurShortGI20MHz Gary Rookard
@ 2023-12-08 1:55 ` Gary Rookard
2023-12-08 1:55 ` [PATCH 4/5] staging: rtl8192e: renamed variable HTIOTActIsCCDFsync Gary Rookard
2023-12-08 17:49 ` [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Philipp Hortmann
4 siblings, 0 replies; 10+ messages in thread
From: Gary Rookard @ 2023-12-08 1:55 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch avoid CamelCase,
rename it. CCKOFDMRate -> cck_of_dm_rate
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 633f735bdab1..73c0204303ec 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -116,13 +116,13 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 mcs_rate)
u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 data_rate)
{
- u16 CCKOFDMRate[12] = {0x02, 0x04, 0x0b, 0x16, 0x0c, 0x12, 0x18,
+ u16 cck_of_dm_rate[12] = {0x02, 0x04, 0x0b, 0x16, 0x0c, 0x12, 0x18,
0x24, 0x30, 0x48, 0x60, 0x6c};
u8 is40MHz = 0;
u8 isShortGI = 0;
if (data_rate < 12)
- return CCKOFDMRate[data_rate];
+ return cck_of_dm_rate[data_rate];
if (data_rate >= 0x10 && data_rate <= 0x1f) {
is40MHz = 0;
isShortGI = 0;
--
2.41.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/5] staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
2023-12-08 1:55 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
` (2 preceding siblings ...)
2023-12-08 1:55 ` [PATCH 3/5] staging: rtl8192e: renamed variable CCKOFDMRate Gary Rookard
@ 2023-12-08 1:55 ` Gary Rookard
2023-12-08 17:49 ` [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Philipp Hortmann
4 siblings, 0 replies; 10+ messages in thread
From: Gary Rookard @ 2023-12-08 1:55 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTIOTActIsCCDFsync -> ht_iot_act_is_ccd_fsync
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 73c0204303ec..5486b1ab4b5a 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -218,7 +218,7 @@ static u8 ht_iot_act_is_mgnt_use_cck_6m(struct rtllib_device *ieee,
return retValue;
}
-static u8 HTIOTActIsCCDFsync(struct rtllib_device *ieee)
+static u8 ht_iot_act_is_ccd_fsync(struct rtllib_device *ieee)
{
u8 retValue = 0;
@@ -662,7 +662,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
bIOTAction = ht_iot_act_is_mgnt_use_cck_6m(ieee, pNetwork);
if (bIOTAction)
ht_info->iot_action |= HT_IOT_ACT_MGNT_USE_CCK_6M;
- bIOTAction = HTIOTActIsCCDFsync(ieee);
+ bIOTAction = ht_iot_act_is_ccd_fsync(ieee);
if (bIOTAction)
ht_info->iot_action |= HT_IOT_ACT_CDD_FSYNC;
} else {
--
2.41.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
2023-12-08 1:55 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
` (3 preceding siblings ...)
2023-12-08 1:55 ` [PATCH 4/5] staging: rtl8192e: renamed variable HTIOTActIsCCDFsync Gary Rookard
@ 2023-12-08 17:49 ` Philipp Hortmann
2023-12-08 21:56 ` Gary Rookard
2023-12-09 0:41 ` Gary Rookard
4 siblings, 2 replies; 10+ messages in thread
From: Philipp Hortmann @ 2023-12-08 17:49 UTC (permalink / raw)
To: Gary Rookard, gregkh; +Cc: linux-staging, linux-kernel
On 12/8/23 02:55, Gary Rookard wrote:
> Hi,
>
> This patch series renames 5 different variables with the checkpatch
> coding style issue, Avoid CamelCase.
>
> Patch 1/5) renamed variable bCurShortGI40MHz
> Patch 2/5) renamed variable bcurShortGI20MHz
> Patch 3/5) renamed variable CCKOFDMRate
> Patch 4/5) renamed variable HTIOTActIsCCDFsync
> Patch 5/5) renamed variable IOTPeer
>
> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>
>
> Gary Rookard (5):
> staging: rtl8192e: renamed variable bCurShortGI40MHz
> staging: rtl8192e: renamed variable bCurShortGI20MHz
> staging: rtl8192e: renamed variable CCKOFDMRate
> staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
> staging: rtl8192e: renamed variable IOTPeer
>
> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
> drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
> drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
> 5 files changed, 47 insertions(+), 47 deletions(-)
>
Please use present-tense as outlined here:
https://kernelnewbies.org/PatchPhilosophy
So rename instead of renamed
Please use a more unique Subject for your coverletter.
It often cannot cover everything. But more unique is better.
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
2023-12-08 17:49 ` [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Philipp Hortmann
@ 2023-12-08 21:56 ` Gary Rookard
2023-12-09 17:16 ` Philipp Hortmann
2023-12-09 0:41 ` Gary Rookard
1 sibling, 1 reply; 10+ messages in thread
From: Gary Rookard @ 2023-12-08 21:56 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: gregkh, linux-staging, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2152 bytes --]
Philipp Hortmann <philipp.g.hortmann@gmail.com> writes:
> On 12/8/23 02:55, Gary Rookard wrote:
>> Hi,
>> This patch series renames 5 different variables with the checkpatch
>> coding style issue, Avoid CamelCase.
>> Patch 1/5) renamed variable bCurShortGI40MHz
>> Patch 2/5) renamed variable bcurShortGI20MHz
>> Patch 3/5) renamed variable CCKOFDMRate
>> Patch 4/5) renamed variable HTIOTActIsCCDFsync
>> Patch 5/5) renamed variable IOTPeer
>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>> Gary Rookard (5):
>> staging: rtl8192e: renamed variable bCurShortGI40MHz
>> staging: rtl8192e: renamed variable bCurShortGI20MHz
>> staging: rtl8192e: renamed variable CCKOFDMRate
>> staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>> staging: rtl8192e: renamed variable IOTPeer
>> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
>> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
>> drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
>> drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
>> drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
>> 5 files changed, 47 insertions(+), 47 deletions(-)
>>
>
>
> Please use present-tense as outlined here:
> https://kernelnewbies.org/PatchPhilosophy
> So rename instead of renamed
>
> Please use a more unique Subject for your coverletter.
> It often cannot cover everything. But more unique is better.
>
>
>
> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Okay, "rename" it be, instead of me thinking in the past simple tense,
of "renamed".
As for the coverletter(s)...repetition a big problem.
There's not much in the way of uniqueness that can be added...regretfully
Tagging the Subject line with a numeric value is possible and
should deviate the coverletter(s) enough so they don't "appear the same".
e.g. staging: rtl8192e: this patch series (1) blah blah blah...
e.g. staging: rtl8192e: this patch series (2) blah blah blah...
e.g. staging: rtl8192e: this patch series (3) " " "
Regards,
Gary
--
Sent with my mu4e on Gentoo GNU/linux.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
2023-12-08 21:56 ` Gary Rookard
@ 2023-12-09 17:16 ` Philipp Hortmann
0 siblings, 0 replies; 10+ messages in thread
From: Philipp Hortmann @ 2023-12-09 17:16 UTC (permalink / raw)
To: Gary Rookard; +Cc: gregkh, linux-staging, linux-kernel
On 12/8/23 22:56, Gary Rookard wrote:
>
> Philipp Hortmann <philipp.g.hortmann@gmail.com> writes:
>
>> On 12/8/23 02:55, Gary Rookard wrote:
>>> Hi,
>>> This patch series renames 5 different variables with the checkpatch
>>> coding style issue, Avoid CamelCase.
>>> Patch 1/5) renamed variable bCurShortGI40MHz
>>> Patch 2/5) renamed variable bcurShortGI20MHz
>>> Patch 3/5) renamed variable CCKOFDMRate
>>> Patch 4/5) renamed variable HTIOTActIsCCDFsync
>>> Patch 5/5) renamed variable IOTPeer
>>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>>> Gary Rookard (5):
>>> staging: rtl8192e: renamed variable bCurShortGI40MHz
>>> staging: rtl8192e: renamed variable bCurShortGI20MHz
>>> staging: rtl8192e: renamed variable CCKOFDMRate
>>> staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>>> staging: rtl8192e: renamed variable IOTPeer
>>> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
>>> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
>>> drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
>>> drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
>>> drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
>>> 5 files changed, 47 insertions(+), 47 deletions(-)
>>>
>>
>>
>> Please use present-tense as outlined here:
>> https://kernelnewbies.org/PatchPhilosophy
>> So rename instead of renamed
>>
>> Please use a more unique Subject for your coverletter.
>> It often cannot cover everything. But more unique is better.
>>
>>
>>
>> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
>
> Okay, "rename" it be, instead of me thinking in the past simple tense,
> of "renamed".
>
> As for the coverletter(s)...repetition a big problem.
>
> There's not much in the way of uniqueness that can be added...regretfully
> Tagging the Subject line with a numeric value is possible and
> should deviate the coverletter(s) enough so they don't "appear the same".
> e.g. staging: rtl8192e: this patch series (1) blah blah blah...
> e.g. staging: rtl8192e: this patch series (2) blah blah blah...
> e.g. staging: rtl8192e: this patch series (3) " " "
>
> Regards,
> Gary
>
Hi Gary
Here is a proposal:
[PATCH 0/5] staging: rtl8192e: Rename variable bCurShortGI40MHz and further
That will give a pretty good recognizable name.
Thanks for your support.
Bye Philipp
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
2023-12-08 17:49 ` [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Philipp Hortmann
2023-12-08 21:56 ` Gary Rookard
@ 2023-12-09 0:41 ` Gary Rookard
1 sibling, 0 replies; 10+ messages in thread
From: Gary Rookard @ 2023-12-09 0:41 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: gregkh, linux-staging, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1835 bytes --]
Philipp Hortmann <philipp.g.hortmann@gmail.com> writes:
> On 12/8/23 02:55, Gary Rookard wrote:
>> Hi,
>> This patch series renames 5 different variables with the checkpatch
>> coding style issue, Avoid CamelCase.
>> Patch 1/5) renamed variable bCurShortGI40MHz
>> Patch 2/5) renamed variable bcurShortGI20MHz
>> Patch 3/5) renamed variable CCKOFDMRate
>> Patch 4/5) renamed variable HTIOTActIsCCDFsync
>> Patch 5/5) renamed variable IOTPeer
>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>> Gary Rookard (5):
>> staging: rtl8192e: renamed variable bCurShortGI40MHz
>> staging: rtl8192e: renamed variable bCurShortGI20MHz
>> staging: rtl8192e: renamed variable CCKOFDMRate
>> staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>> staging: rtl8192e: renamed variable IOTPeer
>> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
>> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
>> drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
>> drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
>> drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
>> 5 files changed, 47 insertions(+), 47 deletions(-)
>>
>
>
> Please use present-tense as outlined here:
> https://kernelnewbies.org/PatchPhilosophy
> So rename instead of renamed
>
> Please use a more unique Subject for your coverletter.
> It often cannot cover everything. But more unique is better.
>
>
>
> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Okay, will use "rename" instead past simple tense "renamed"
The coverletter(s) are having a repetition problem, I can add an
numeric value to their Subject lines to "unique" them as there is not much
else available to do so with.
Regards,
Gary
--
Sent with my mu4e on Gentoo GNU/linux.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread