From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5618C10F05 for ; Thu, 7 Dec 2023 14:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443329AbjLGOif (ORCPT ); Thu, 7 Dec 2023 09:38:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235280AbjLGOie (ORCPT ); Thu, 7 Dec 2023 09:38:34 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74BA5AC for ; Thu, 7 Dec 2023 06:38:40 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C28A11FB76; Thu, 7 Dec 2023 14:38:38 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6E28213976; Thu, 7 Dec 2023 14:38:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id kkNYGe7YcWUWOQAAD6G6ig (envelope-from ); Thu, 07 Dec 2023 14:38:38 +0000 Date: Thu, 07 Dec 2023 15:38:37 +0100 Message-ID: <87y1e6yt5e.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Gergo Koteles , Shenghao Ding , Kevin Lu , Baojun Xu , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 00/16] ALSA: hda/tas2781: Add tas2563 support In-Reply-To: <85b7456d-7cf3-4885-8e71-111df53e35fe@sirena.org.uk> References: <85b7456d-7cf3-4885-8e71-111df53e35fe@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [7.79 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_SOFTFAIL(4.60)[~all:c]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[10]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(2.20)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[irl.hu,ti.com,perex.cz,suse.com,gmail.com,vger.kernel.org,alsa-project.org]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[17.80%]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spamd-Bar: +++++++ Authentication-Results: smtp-out2.suse.de; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none); spf=softfail (smtp-out2.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tiwai@suse.de) smtp.mailfrom=tiwai@suse.de X-Rspamd-Server: rspamd1 X-Rspamd-Queue-Id: C28A11FB76 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 07 Dec 2023 14:55:25 +0100, Mark Brown wrote: > > On Thu, Dec 07, 2023 at 01:58:22AM +0100, Gergo Koteles wrote: > > > Gergo Koteles (16): > > ASoC: tas2781: add support for fw version 0x0503 > > ALSA: hda/tas2781: leave hda_component in usable state > > ASoC: tas2781: disable regmap regcache > > ALSA: hda/tas2781: handle missing calibration data > > ALSA: hda/tas2781: fix typos in comment > > ASoC: tas2781: add ptrs to calibration functions > > ALSA: hda/tas2781: load_calibration just load > > ASoC: tas2781: add configurable global_addr > > ALSA: hda/tas2781: add TAS2563 support for 14ARB7 > > ASoC: tas2781: check negative indexes > > ASoC: tas2781: use 0 as default prog/conf index > > ASoC: tas2781: move set_drv_data outside tasdevice_init > > ALSA: hda/tas2781: remove sound controls in unbind > > ALSA: hda/tas2781: call cleaner functions only once > > ALSA: hda/tas2781: reset the amp before component_add > > ALSA: hda/tas2781: configure the amp after firmware load > > Please don't randomly interleave ASoC and ALSA patches like this without > some strong need, it just makes everything harder to manage. And, some look really like rather individual fixes; they deserve for Fixes tag and Cc-to-stable, at least. thanks, Takashi