public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Yuan Tan <tanyuan@tinylab.org>, christophe.leroy@csgroup.eu
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	falcon@tinylab.org, w@1wt.eu, linux@weissschuh.net,
	tanyuan@tinylab.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v3 1/3] powerpc/config: Cleanup pmac32_defconfig
Date: Thu, 14 Sep 2023 23:10:08 +1000	[thread overview]
Message-ID: <87y1h87vf3.fsf@mail.lhotse> (raw)
In-Reply-To: <23b30e8e9e31e7a6af4aa7d317699e1538ad89c2.1694685860.git.tanyuan@tinylab.org>

Yuan Tan <tanyuan@tinylab.org> writes:
> Use 'make savedefconfig' to cleanup pmac32_defconfig, based on Linux
> 7.6-rc1

Thanks but I don't like doing these updates in a single commit like
this, it's easy to accidentally lose a symbol.

I prefer an explanation for what's changing for each symbol. See
1ce7fda142af ("powerpc/configs/64s: Drop IPV6 which is default y") and
the commits leading up to it, to see what I mean.

But I suspect you probably don't want to go to all that effort, which is
fine :)

So I won't take patch 1, but patch 2 and 3 look fine. No need to resend,
I'll deal with any merge fixup needed.

cheers

  reply	other threads:[~2023-09-14 13:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 10:09 [PATCH v3 0/3] Kconfig: Add dependencies of POWER_RESET for pmac32 Yuan Tan
2023-09-14 10:10 ` [PATCH v3 1/3] powerpc/config: Cleanup pmac32_defconfig Yuan Tan
2023-09-14 13:10   ` Michael Ellerman [this message]
2023-09-14 14:37     ` Yuan Tan
2023-09-21 23:50       ` Michael Ellerman
2023-09-14 10:10 ` [PATCH v3 2/3] Kconfig: Add dependencies of POWER_RESET for pmac32 Yuan Tan
2023-09-14 10:10 ` [PATCH v3 3/3] powerpc/config: Simplify pmac32_defconfig Yuan Tan
2023-09-21  9:30 ` (subset) [PATCH v3 0/3] Kconfig: Add dependencies of POWER_RESET for pmac32 Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1h87vf3.fsf@mail.lhotse \
    --to=mpe@ellerman.id.au \
    --cc=christophe.leroy@csgroup.eu \
    --cc=falcon@tinylab.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=philmd@linaro.org \
    --cc=tanyuan@tinylab.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox