From: Marian Postevca <posteuca@mutex.one>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] ASoC: es8316: Enable support for S32 LE format
Date: Sat, 26 Aug 2023 00:55:21 +0300 [thread overview]
Message-ID: <87y1hypz1y.fsf@mutex.one> (raw)
In-Reply-To: <ZOfMo4Cb2zd1Km3H@finisterre.sirena.org.uk>
Mark Brown <broonie@kernel.org> writes:
>> To properly support a line of Huawei laptops with AMD CPU and a
>> ES8336 codec connected to the ACP3X module we need to enable
>> the S32 LE format.
>
> What's the issue? The AMD code looks like it supports plenty of other
> formats in most places.
In previous version of the machine driver I used a different CPU
component than acp-i2s-sp. For that one, I couldn't get it to have
sound unless I specifically requested S32 LE format.
I removed S32_LE from the CODEC to test if it works and it
seems it does work with acp-is2-sp. Format S16_LE is chosen by
both components and sound can be heard. I guess this patch is
not really needed.
next prev parent reply other threads:[~2023-08-25 21:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 21:01 [PATCH v2 0/4] ASoC: amd: acp: Add sound support for a line of HUAWEI laptops Marian Postevca
2023-08-24 21:01 ` [PATCH v2 1/4] ASoC: es8316: Enable support for S32 LE format Marian Postevca
2023-08-24 21:33 ` Mark Brown
2023-08-25 21:55 ` Marian Postevca [this message]
2023-08-26 11:24 ` Mark Brown
2023-08-24 21:01 ` [PATCH v2 2/4] ASoC: es8316: Enable support for MCLK div by 2 Marian Postevca
2023-08-24 21:53 ` Mark Brown
2023-08-27 21:50 ` Marian Postevca
2023-08-28 18:09 ` Mark Brown
2023-08-28 20:22 ` Marian Postevca
2023-08-29 10:18 ` Mark Brown
2023-08-24 21:01 ` [PATCH v2 3/4] ASoC: amd: acp: Add support for splitting the codec specific code from the ACP driver Marian Postevca
2023-08-24 21:01 ` [PATCH v2 4/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec Marian Postevca
2023-08-24 22:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1hypz1y.fsf@mutex.one \
--to=posteuca@mutex.one \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox