public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Hindborg (Samsung)" <nmi@metaspace.dk>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "Ming Lei" <ming.lei@redhat.com>,
	"hch@infradead.org" <hch@infradead.org>,
	"gost.dev@samsung.com" <gost.dev@samsung.com>,
	"open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
	"Hans Holmberg" <Hans.Holmberg@wdc.com>,
	"Matias Bjørling" <Matias.Bjorling@wdc.com>,
	"Minwoo Im" <minwoo.im.dev@gmail.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Johannes Thumshirn" <jth@kernel.org>,
	"Aravind Ramesh" <Aravind.Ramesh@wdc.com>,
	"Damien Le Moal" <dlemoal@kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 3/3] ublk: enable zoned storage support
Date: Fri, 04 Aug 2023 10:59:03 +0200	[thread overview]
Message-ID: <87y1irw1zh.fsf@metaspace.dk> (raw)
In-Reply-To: <f339913a-3f73-5fc3-27d1-73491a8028a7@wdc.com>


Johannes Thumshirn <Johannes.Thumshirn@wdc.com> writes:

> On 03.08.23 16:09, Andreas Hindborg (Samsung) wrote:
>> + buf = __vmalloc(bufsize, GFP_KERNEL | __GFP_NORETRY);
>
> Missing #include <linux/vmalloc.h> so the bot doesn't complain.

Thanks, gotta add that so code compiles for Sega Dreamcast!

> But while we're at it, why can't you just use kvmalloc() here?

I don't see why not. It should be better for small reports I guess. I will change it.

BR Andreas


  reply	other threads:[~2023-08-04 10:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03 14:06 [PATCH v10 0/3] ublk: enable zoned storage support Andreas Hindborg (Samsung)
2023-08-03 14:06 ` [PATCH v10 1/3] ublk: add helper to check if device supports user copy Andreas Hindborg (Samsung)
2023-08-03 19:02   ` Johannes Thumshirn
2023-08-03 14:07 ` [PATCH v10 2/3] ublk: move check for empty address field on command submission Andreas Hindborg (Samsung)
2023-08-04  9:01   ` Ming Lei
2023-08-04 10:08     ` Andreas Hindborg (Samsung)
2023-08-03 14:07 ` [PATCH v10 3/3] ublk: enable zoned storage support Andreas Hindborg (Samsung)
2023-08-03 18:58   ` kernel test robot
2023-08-03 19:07   ` Johannes Thumshirn
2023-08-04  8:59     ` Andreas Hindborg (Samsung) [this message]
2023-08-04 10:25       ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1irw1zh.fsf@metaspace.dk \
    --to=nmi@metaspace.dk \
    --cc=Aravind.Ramesh@wdc.com \
    --cc=Hans.Holmberg@wdc.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=Matias.Bjorling@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=gost.dev@samsung.com \
    --cc=hch@infradead.org \
    --cc=jth@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=minwoo.im.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox