From: Takashi Iwai <tiwai@suse.de>
To: "Jarkko Sakkinen" <jarkko@kernel.org>
Cc: "Peter Huewe" <peterhuewe@gmx.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Lino Sanfilippo" <l.sanfilippo@kunbus.com>,
<linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7
Date: Sat, 29 Jul 2023 10:45:58 +0200 [thread overview]
Message-ID: <87y1izcdh5.wl-tiwai@suse.de> (raw)
In-Reply-To: <878razdwnh.wl-tiwai@suse.de>
On Sat, 29 Jul 2023 09:06:26 +0200,
Takashi Iwai wrote:
>
> On Fri, 28 Jul 2023 21:24:30 +0200,
> Jarkko Sakkinen wrote:
> >
> > On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote:
> > > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on
> > > tpm_tis like a few other laptops. Add an entry for the workaround.
> > >
> > > Cc: stable@vger.kernel.org
> > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
> > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > ---
> > > drivers/char/tpm/tpm_tis.c | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> > > index cc42cf3de960..a98773ac2e55 100644
> > > --- a/drivers/char/tpm/tpm_tis.c
> > > +++ b/drivers/char/tpm/tpm_tis.c
> > > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> > > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"),
> > > },
> > > },
> > > + {
> > > + .callback = tpm_tis_disable_irq,
> > > + .ident = "TUXEDO InfinityBook S 15/17 Gen7",
> > > + .matches = {
> > > + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
> > > + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"),
> > > + },
> > > + },
> > > {
> > > .callback = tpm_tis_disable_irq,
> > > .ident = "UPX-TGL",
> > > --
> > > 2.35.3
> >
> > Hi does this occur with the latest linux-next and/or v6.5-rc3?
>
> Not tested yet, but do you have any relevant fix except for the commit
> 481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled
> IRQs")? That commit was already tested, at least.
And now it's confirmed that the problem persists with 6.5-rc3.
thanks,
Takashi
next prev parent reply other threads:[~2023-07-29 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 18:00 [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7 Takashi Iwai
2023-07-28 19:24 ` Jarkko Sakkinen
2023-07-29 7:06 ` Takashi Iwai
2023-07-29 8:45 ` Takashi Iwai [this message]
2023-07-31 10:58 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1izcdh5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox