From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B29C04A6A for ; Sat, 29 Jul 2023 08:46:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231389AbjG2IqG (ORCPT ); Sat, 29 Jul 2023 04:46:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231317AbjG2IqC (ORCPT ); Sat, 29 Jul 2023 04:46:02 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2DF0130; Sat, 29 Jul 2023 01:46:00 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 451E321877; Sat, 29 Jul 2023 08:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690620359; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gcYU5/tW+ecPEEB3LYPQdNS3y4Aut8BuE47yfQe7UTk=; b=pzRvM+Jgf+Xj8nccUrWTQ/rAB3NLJRO7HHLRujlPNQF1U0c+pqBMmVzYCrIoxCk+kBsgdf iMdvBTjM+qJIcIBiSKE0Flg2fVOdqU+dmhVC68Nvq7g1MYsYF29TR9nOCJapzDkko8YPGo m9lW8zBzcDYElbFqoufITHWu3VJXj/g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690620359; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gcYU5/tW+ecPEEB3LYPQdNS3y4Aut8BuE47yfQe7UTk=; b=6kK5VQCTF0hR3xqwbS82R58f0HaT4g+2hgUq65vT6ifGc2P6XfxcMGsawaHB+8VoqJH2tM tcCIk4Yes4NNO/CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 145B113922; Sat, 29 Jul 2023 08:45:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fueHA8fRxGTpOAAAMHmgww (envelope-from ); Sat, 29 Jul 2023 08:45:59 +0000 Date: Sat, 29 Jul 2023 10:45:58 +0200 Message-ID: <87y1izcdh5.wl-tiwai@suse.de> From: Takashi Iwai To: "Jarkko Sakkinen" Cc: "Peter Huewe" , "Jason Gunthorpe" , "Lino Sanfilippo" , , Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7 In-Reply-To: <878razdwnh.wl-tiwai@suse.de> References: <20230726180035.14511-1-tiwai@suse.de> <878razdwnh.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 29 Jul 2023 09:06:26 +0200, Takashi Iwai wrote: > > On Fri, 28 Jul 2023 21:24:30 +0200, > Jarkko Sakkinen wrote: > > > > On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote: > > > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on > > > tpm_tis like a few other laptops. Add an entry for the workaround. > > > > > > Cc: stable@vger.kernel.org > > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645 > > > Signed-off-by: Takashi Iwai > > > --- > > > drivers/char/tpm/tpm_tis.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > > > index cc42cf3de960..a98773ac2e55 100644 > > > --- a/drivers/char/tpm/tpm_tis.c > > > +++ b/drivers/char/tpm/tpm_tis.c > > > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > > > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), > > > }, > > > }, > > > + { > > > + .callback = tpm_tis_disable_irq, > > > + .ident = "TUXEDO InfinityBook S 15/17 Gen7", > > > + .matches = { > > > + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > > > + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"), > > > + }, > > > + }, > > > { > > > .callback = tpm_tis_disable_irq, > > > .ident = "UPX-TGL", > > > -- > > > 2.35.3 > > > > Hi does this occur with the latest linux-next and/or v6.5-rc3? > > Not tested yet, but do you have any relevant fix except for the commit > 481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled > IRQs")? That commit was already tested, at least. And now it's confirmed that the problem persists with 6.5-rc3. thanks, Takashi