From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62005EB64DA for ; Sat, 17 Jun 2023 10:23:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235759AbjFQKXY (ORCPT ); Sat, 17 Jun 2023 06:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233330AbjFQKXX (ORCPT ); Sat, 17 Jun 2023 06:23:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D6F31FF7; Sat, 17 Jun 2023 03:23:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D10B6090A; Sat, 17 Jun 2023 10:23:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9E6CC433C8; Sat, 17 Jun 2023 10:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686997400; bh=48DNRdGhwlp2Rq1rRI6gQW+WFVFFmBcKDdyEK86n294=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JoWBtk7Js0E7rBJRtpGJgSzeNbnPh0jGo1zuQB3tlHhQot6mzbzdkp2zxUqVVETVI 45yyFSv8hWM9Oke1Ua1IaZgaSHwfkXZNZgv72oTxIcz3618o9+oBNWkdWYOq8LHvMv nm/Uj2xZ22/YuWmKiLeXZ+rH6zlwVwwj5U+5l5MJerEBF0cl95QPparsv57LtQdI2Y 0Wz0u/vf5qusM+M/4TEmDpaLAtjydC96R/6Yb6JdNb8V7NKUgHIQQOG+PWdmjQaxdO CUr/Qv1seDGPvTVpKK+05euarkQ9tJSsz0Cmn64hgEAU0kmIozH2nqVw5T9FcPpON+ DD2oWcTBaY62A== Received: from 82-132-214-193.dab.02.net ([82.132.214.193] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qAT5S-0064hw-29; Sat, 17 Jun 2023 11:23:18 +0100 Date: Sat, 17 Jun 2023 11:23:17 +0100 Message-ID: <87y1kipeui.wl-maz@kernel.org> From: Marc Zyngier To: Linus Walleij Cc: Andy Shevchenko , Thierry Reding , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Andy Shevchenko Subject: Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip In-Reply-To: References: <20230616135313.76338-1-andriy.shevchenko@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 82.132.214.193 X-SA-Exim-Rcpt-To: linus.walleij@linaro.org, andriy.shevchenko@linux.intel.com, treding@nvidia.com, bartosz.golaszewski@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@bgdev.pl, andy@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 17 Jun 2023 10:08:10 +0100, Linus Walleij wrote: >=20 > On Fri, Jun 16, 2023 at 3:53=E2=80=AFPM Andy Shevchenko > wrote: >=20 > > It seems there is no driver that requires custom IRQ chip > > domain options. Drop the member and respective code. > > > > Signed-off-by: Andy Shevchenko > (...) > > - /* Some drivers provide custom irqdomain ops */ > > gc->irq.domain =3D irq_domain_create_simple(fwnode, > > gc->ngpio, > > gc->irq.first, > > - gc->irq.domain_ops ?: &gpiochip_domain_ops, > > + &gpiochip_domain_ops, >=20 > We better run this by Marc Zyngier, and Thierry who introduced it. >=20 > But some grepping and looking seems to conclude you are righ! > Reviewed-by: Linus Walleij No objection from my end. If this is unused, let's kill it. Acked-by: Marc Zyngier M. --=20 Without deviation from the norm, progress is not possible.