From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD351C636F9 for ; Fri, 2 Dec 2022 19:29:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234782AbiLBT3u (ORCPT ); Fri, 2 Dec 2022 14:29:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234167AbiLBT3q (ORCPT ); Fri, 2 Dec 2022 14:29:46 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC181EC80E for ; Fri, 2 Dec 2022 11:29:45 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1670009384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hjDSkUH0p+tY8l0rmcBtgIY2pcEuGoRGi40mhKIE2SY=; b=A5CdhnpmJv/Ucs9jhukCRT+TAIyOTXmaZcx6PSknpfwM+sSpNPYNnL0qRLW0FtsTije5KV 5+vWHvDKGhvQQa/uzr5M3EDrb6JXGspPD24X+renn3XJG0ORpO49wN2prqIn2yW7drr87I m9pq03/E2far2fZXin9hVgO8kIK7n2G6sC1iulfPlYfCqPKhkoJb4TD6Z8NBX9/1j1IvpO YHsMVN7BmcOSyr0XivT8q2j1Pspq7ZdCs9yHWq0h8KHj7bFknllCQS+LsWXrmdDXinUgDU eyi1I/GKNRLM9i07mg9hG6Ic061BFxd7O7UK9f/hNJUbrhs1/TI8I9xb+MkYbA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1670009384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hjDSkUH0p+tY8l0rmcBtgIY2pcEuGoRGi40mhKIE2SY=; b=4kpqtHHvDB36JlGi87jNK4zrXZFvAPiqkx8/E5xlj9ik9rXQELs2YO8fy1UiTeGafbvSmI iMUyUvCVJBjPT6AA== To: Ashok Raj , Borislav Petkov Cc: X86-kernel , LKML Mailing List , Ashok Raj , Dave Hansen , Tony Luck , alison.schofield@intel.com, reinette.chatre@intel.com Subject: Re: [Patch V1 6/7] x86/microcode/intel: Print old and new rev during early boot In-Reply-To: <20221129210832.107850-7-ashok.raj@intel.com> References: <20221129210832.107850-1-ashok.raj@intel.com> <20221129210832.107850-7-ashok.raj@intel.com> Date: Fri, 02 Dec 2022 20:29:44 +0100 Message-ID: <87y1rpob87.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 29 2022 at 13:08, Ashok Raj wrote: > Make early loading message to match late loading messages. Print > both old and new revisions. > > This is helpful to know what the BIOS loaded revision is before an early > update. > > microcode: early update: 0x2b000041 -> 0x2b000070 date = 2000-01-01 > > Store the early BIOS revision and change the print format to match > late loading message from microcode/core.c Cache the early BIOS revision before the microcode update and change print_ucode_info() so it prints both the old and the new revision in the same format as $function(). > */ > static void > -print_ucode_info(unsigned int new_rev, unsigned int date) > +print_ucode_info(int old_rev, int new_rev, unsigned int date) Oh. Forgot to mention that before. Can you please get rid of this pointless line break after 'static void' ? > { > - pr_info_once("microcode updated early to revision 0x%x, date = %04x-%02x-%02x\n", > - new_rev, > + pr_info_once("early update: 0x%x -> 0x%x, date = %04x-%02x-%02x\n", > + old_rev, new_rev, > date & 0xffff, > date >> 24, > (date >> 16) & 0xff); And while at it also consolidate these arguments into a single or at max. two lines? Should happen in the first patch which touches this function. Other than that, the code is fine. Thanks, tglx