From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: syzbot <syzbot+9abda841d636d86c41da@syzkaller.appspotmail.com>,
alsa-devel-owner@alsa-project.org, alsa-devel@alsa-project.org,
clemens@ladisch.de, gregkh@linuxfoundation.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
peda@axentia.se, perex@perex.cz, rafael@kernel.org,
syzkaller-bugs@googlegroups.com, tiwai@suse.com
Subject: Re: [syzbot] WARNING in snd_usbmidi_output_open
Date: Sat, 12 Nov 2022 15:10:21 +0100 [thread overview]
Message-ID: <87y1sg1cxe.wl-tiwai@suse.de> (raw)
In-Reply-To: <Y2+hCnVYWHuROAEF@sirena.org.uk>
On Sat, 12 Nov 2022 14:35:06 +0100,
Mark Brown wrote:
>
> On Sat, Nov 12, 2022 at 05:29:21AM -0800, syzbot wrote:
> > syzbot has bisected this issue to:
> >
> > commit 4f8ed19593872b710f27bbc3b7a9ce03310efc57
> > Author: Mark Brown <broonie@kernel.org>
> > Date: Thu Jun 2 13:10:58 2022 +0000
> >
> > ASoC: tfa9879: Use modern ASoC DAI format terminology
>
> This bisection really doesn't seem credible for an issue in a different
> driver... The tfa9879 is neither a USB nor MIDI device, and the commit
> in question is a stylistic update.
Yes, the bisection result is bogus.
And, the problem here is just a kernel WARNING produced by
snd_BUG_ON() macro usage, and the check itself is valid.
We just need to drop snd_BUG_ON() wrapping.
Will submit the fix later.
thanks,
Takashi
prev parent reply other threads:[~2022-11-12 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 18:26 [syzbot] WARNING in snd_usbmidi_output_open syzbot
2022-11-12 13:29 ` syzbot
2022-11-12 13:35 ` Mark Brown
2022-11-12 14:10 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1sg1cxe.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel-owner@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=clemens@ladisch.de \
--cc=gregkh@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=rafael@kernel.org \
--cc=syzbot+9abda841d636d86c41da@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox