From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D19C4332F for ; Mon, 7 Nov 2022 23:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231659AbiKGXqE (ORCPT ); Mon, 7 Nov 2022 18:46:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232538AbiKGXqB (ORCPT ); Mon, 7 Nov 2022 18:46:01 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B02AE1BE8A for ; Mon, 7 Nov 2022 15:45:59 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1667864756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tJpXilJJ1kzzx00V2iygh4nhzFSutURlpOx4SGA14uA=; b=FWE7BDlqYAMHTT1SJ30pNL+SqokfR9h/m12iACtZZ43WKYeZbFyAdHTpns7swUJbuo+dbn AsEHL0Z9vLiq0djNF9pW2NlygDy2u+U7VxYdGpRf4eq5YtjN2qFI5VWk5ZEk0DexMBrB9j 0nvJk2f3207hdD+pzdCuX2+2ZQF9UQ49pOt0Xa8nuWcN/jFthS3OAocC8JwI+3Fy8ZkioS 9uZeLWpgmtjnwBn4ImTof9QeDBH8L6wCZXWwTm/On1NqF72vKdC3sGE8pbh8NS1vZ9pJOn zTHpFejSt1dsyJSmV9I5otGD9PkGwnhgMxHTfnegsBxhJNVdWa1DBfsDaYrtvg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1667864756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tJpXilJJ1kzzx00V2iygh4nhzFSutURlpOx4SGA14uA=; b=Y0sYVhLypXw8UFv8HGsnFO6bAIWZK47+WF2PUXNF1fhAvFfHUpnyWavFPb7dqMdQkdt4Au lrQuJGm9ERJWKoBQ== To: Steven Rostedt , linux-kernel@vger.kernel.org Cc: Linus Torvalds , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Julia Lawall Subject: Re: [for-linus][PATCH 4/5] timers: Add timer_shutdown_sync() and timer_shutdown() to be called before freeing timers In-Reply-To: References: <20221106233037.815236769@goodmis.org> <20221106233434.425162916@goodmis.org> <87sfivvy91.ffs@tglx> <87mt93vwv4.ffs@tglx> Date: Tue, 08 Nov 2022 00:45:55 +0100 Message-ID: <87y1sm8h1o.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07 2022 at 05:43, Steven Rostedt wrote: > On November 7, 2022 3:15:43 AM PST, Thomas Gleixner wrote: >>On Mon, Nov 07 2022 at 11:45, Thomas Gleixner wrote: >>> On Sun, Nov 06 2022 at 18:30, Steven Rostedt wrote: >>>> >>>> Link: https://lore.kernel.org/all/87pmlrkgi3.ffs@tglx/ >>>> Link: https://lkml.kernel.org/r/20221106212702.363575800@goodmis.org >>>> Link: https://lore.kernel.org/all/20221105060024.598488967@goodmis.org/ >>>> >>>> Cc: Linus Torvalds >>>> Cc: Thomas Gleixner >>>> Cc: Stephen Boyd >>>> Cc: Anna-Maria Gleixner >>>> Cc: Andrew Morton >>>> Cc: Julia Lawall >>>> Tested-by: Guenter Roeck >>>> Signed-off-by: Steven Rostedt (Google) >>> >>> And please follow the guidelines of the tip tree for changelogs and tags. >>> >>> I'll just grab it from the list and let my scripts run over it. >> >>Duh. This thing is unreviewable. >> >>Can you please split it up into pieces which are digestable? > > Sure, but I'm traveling this week and may not get to it until Friday. That's fine as I think this whole approach is wrong to begin with. We are not doing a tree wide change at rc4 just to scratch an itch which is there for ages and has been debated for months. Q: Did you try a merge of the result against -next? A: Definitely not. The proper approach is to provide all the infrastructure, i.e. the new interfaces and merge them during the next merge window. Right before rc1 provide a script or a script converted tree to Linus which switches the tree over to the new world order. How long have you been around doing kernel development and how much fuzz do you make about even trivial changes to ftrace? Thanks, tglx