From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E9ACCA489 for ; Tue, 26 Jul 2022 07:30:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238149AbiGZHaa (ORCPT ); Tue, 26 Jul 2022 03:30:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238913AbiGZHaE (ORCPT ); Tue, 26 Jul 2022 03:30:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B624313A9; Tue, 26 Jul 2022 00:26:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EFC9A6140C; Tue, 26 Jul 2022 07:26:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B671C341C0; Tue, 26 Jul 2022 07:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658820408; bh=veRkIDCqptkOgNvN8gKZoJ3NMTYgf1l2jaf1qWS1GnQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tJ98ozpGXZLxxh2hAnUgk7iPv89n7i8DJmPzndfWoo/JJQ4pnmzqCV+qXUZrEJKTX lg8nIMxmyKe/xRi8c3vYl7IFMePgjr9RjVuz8/I6Z4LaBxeXSE6BbfLg5TuPWFLK2P RYm30YO2vWBUyCQCuYuFGfcEqf/advCvJjnfcfY4vVqjBy/vyrOT2SIHTC1+GBRTMt TJ2cBEg/AaAL4EGejBP8GBMR+bKYQj+Tar65QJNMs6JTUtEOOVj/Bpf/Qnak/zgLLU tWOtLAq3TKELEIk3b7P2LP9aSXd1yxqDYVf/RE/SVd49aZT9MV0htZOVh0D+Gm9VST dMKgugyK9VBUA== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oGExp-00A0re-SJ; Tue, 26 Jul 2022 08:26:46 +0100 Date: Tue, 26 Jul 2022 08:26:43 +0100 Message-ID: <87y1wgbah8.wl-maz@kernel.org> From: Marc Zyngier To: Cc: , , , , , , , , , , , , , Subject: Re: Why set .suppress_bind_attrs even though .remove() implemented? In-Reply-To: References: <20220721222122.GA1754784@bhelgaas> <20220722143905.GA1818909@bhelgaas> <87k085xekg.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: Conor.Dooley@microchip.com, helgaas@kernel.org, pali@kernel.org, johan+linaro@kernel.org, kishon@ti.com, songxiaowei@hisilicon.com, wangbinghui@hisilicon.com, thierry.reding@gmail.com, ryder.lee@mediatek.com, jianjun.wang@mediatek.com, linux-pci@vger.kernel.org, kw@linux.com, ley.foon.tan@intel.com, linux-kernel@vger.kernel.org, Daire.McNamara@microchip.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jul 2022 18:49:05 +0100, wrote: > > Sorry to butt back in here - but I am taking this to mean that rather > than add a remove callback for the microchip pci controller driver when > making it buildable as a module it would instead be better to forgo that > entirely and prevent unloading the module (since it does INTX & MSI). > > Would that be an accurate assessment? Yes. M. -- Without deviation from the norm, progress is not possible.