From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C11EC433EF for ; Thu, 5 May 2022 15:06:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381128AbiEEPJv (ORCPT ); Thu, 5 May 2022 11:09:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381152AbiEEPJU (ORCPT ); Thu, 5 May 2022 11:09:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0AF01CB22; Thu, 5 May 2022 08:05:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DA7B61BB6; Thu, 5 May 2022 15:05:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2778C385A8; Thu, 5 May 2022 15:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651763138; bh=AV7Ctm48EGltuTuBFDYE7IrEPNSYirdqxElT2gUK6aA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Cuvz24GWC9Qj3KZZ53ITYSvcMm/bfiFx/kZzyWAwYEtWo11Jj37pz4GQQQD22LV77 +7Ae6IIZbVryRwEOD1Bxjuurptoy5/xtLQ9MW7c5hdQ45SC4M0eRKB4uses+Z1ak2P b+S+q/8Oa5uGFV1kQKrh6NJPJanNyWuY6Kaf8NddYfZdPTD7Psmy++ZAEEJFcObXmz uSle+r3FeYBqKXxLIP6sK8GofGsuglJUajLGFnXgzLhPKsTtzqDpFNOiOZydwn9ZcM Y58KyBWpG8QlBykTURyXxB+uvR5coBptIV02sndeiljhmMqDZLjP9XKZbAoqvoWRue nCRP4vtwqiK+w== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nmd2u-009EuL-7S; Thu, 05 May 2022 16:05:36 +0100 Date: Thu, 05 May 2022 16:05:36 +0100 Message-ID: <87y1zg6mv3.wl-maz@kernel.org> From: Marc Zyngier To: Linus Walleij Cc: Michael Walle , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: microchip-sgpio: make irq_chip immutable In-Reply-To: References: <20220428111622.1395831-1-michael@walle.cc> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linus.walleij@linaro.org, michael@walle.cc, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 May 2022 15:55:01 +0100, Linus Walleij wrote: > > On Thu, Apr 28, 2022 at 1:16 PM Michael Walle wrote: > > > Since recently, the kernel is nagging about mutable irq_chips: > > > > [ 4.967050] gpio gpiochip1: (e2004190.gpio-input): not an immutable chip, please consider fixing it! > > > > Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new > > helper functions and call the appropriate gpiolib functions. > > > > Signed-off-by: Michael Walle > > Patch applied after pulling in Marc's immutable branch. > > (Hm a bit confusing since it is a immutable branch with code > for immutable GPIO chips ... I assume it is both.) Both indeed. Immutable^2, or something like that. M. -- Without deviation from the norm, progress is not possible.