From: Thomas Gleixner <tglx@linutronix.de>
To: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
David Hildenbrand <david@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Tony Luck <tony.luck@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
Sean Christopherson <seanjc@google.com>,
Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/6] x86/boot: Avoid #VE during boot for TDX platforms
Date: Sun, 17 Oct 2021 21:49:16 +0200 [thread overview]
Message-ID: <87y26r3003.ffs@tglx> (raw)
In-Reply-To: <20211005230550.1819406-3-sathyanarayanan.kuppuswamy@linux.intel.com>
On Tue, Oct 05 2021 at 16:05, Kuppuswamy Sathyanarayanan wrote:
>
> /* Enable PAE and LA57 (if required) paging modes */
> - movl $X86_CR4_PAE, %eax
> + movl %cr4, %eax
> + /*
> + * Clear all bits except CR4.MCE, which is preserved.
> + * Clearing CR4.MCE will #VE in TDX guests.
Sure. But what's the side effect for non TDX?
> + */
> + andl $X86_CR4_MCE, %eax
> + orl $X86_CR4_PAE, %eax
> testl %edx, %edx
> jz 1f
> orl $X86_CR4_LA57, %eax
> @@ -662,8 +670,8 @@ SYM_CODE_START(trampoline_32bit_src)
> pushl $__KERNEL_CS
> pushl %eax
>
> - /* Enable paging again */
> - movl $(X86_CR0_PG | X86_CR0_PE), %eax
> + /* Enable paging again. Avoid clearing X86_CR0_NE for TDX */
Ditto.
The changelog is not providing any information either.
Also instead of '... TDX' all over the place please add sensible defines
and add comments to those in one place. There is really no need to
sprinkle TDX all over the place.
Thanks,
tglx
next prev parent reply other threads:[~2021-10-17 19:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 23:05 [PATCH v7 0/6] Add TDX Guest Support (boot support) Kuppuswamy Sathyanarayanan
2021-10-05 23:05 ` [PATCH v7 1/6] x86/boot: Add a trampoline for APs booting in 64-bit mode Kuppuswamy Sathyanarayanan
2021-10-05 23:05 ` [PATCH v7 2/6] x86/boot: Avoid #VE during boot for TDX platforms Kuppuswamy Sathyanarayanan
2021-10-17 19:49 ` Thomas Gleixner [this message]
2021-10-05 23:05 ` [PATCH v7 3/6] x86/topology: Disable CPU online/offline control for TDX guest Kuppuswamy Sathyanarayanan
2021-10-17 19:23 ` Thomas Gleixner
2021-10-17 19:28 ` Sathyanarayanan Kuppuswamy
2021-10-05 23:05 ` [PATCH v7 4/6] x86/tdx: Forcefully disable legacy PIC for TDX guests Kuppuswamy Sathyanarayanan
2021-10-05 23:05 ` [PATCH v7 5/6] x86: Skip WBINVD instruction for VM guest Kuppuswamy Sathyanarayanan
2021-10-05 23:05 ` [PATCH v7 6/6] x86/split_lock: Fix the split lock #AC handling when running as guest Kuppuswamy Sathyanarayanan
2021-10-13 20:30 ` Sean Christopherson
2021-10-13 21:32 ` Sathyanarayanan Kuppuswamy
2021-10-14 1:24 ` Xiaoyao Li
2021-10-14 2:21 ` Sathyanarayanan Kuppuswamy
2021-10-14 15:04 ` Sean Christopherson
2021-10-15 1:30 ` Xiaoyao Li
2021-10-06 8:21 ` [PATCH v7 0/6] Add TDX Guest Support (boot support) David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y26r3003.ffs@tglx \
--to=tglx@linutronix.de \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=knsathya@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox