From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72308C433EF for ; Mon, 4 Oct 2021 16:09:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5828D61373 for ; Mon, 4 Oct 2021 16:09:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237035AbhJDQKN (ORCPT ); Mon, 4 Oct 2021 12:10:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:38364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236253AbhJDQJQ (ORCPT ); Mon, 4 Oct 2021 12:09:16 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB2D261175; Mon, 4 Oct 2021 16:07:27 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mXQUv-00EfzA-P1; Mon, 04 Oct 2021 17:07:25 +0100 Date: Mon, 04 Oct 2021 17:07:25 +0100 Message-ID: <87y278rcxu.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH] irqdomain: Export __irq_domain_alloc_irqs() to modules In-Reply-To: <20211004155915.GA25619@lpieralisi> References: <20211004150552.3844830-1-maz@kernel.org> <20211004155915.GA25619@lpieralisi> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lorenzo.pieralisi@arm.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Oct 2021 16:59:15 +0100, Lorenzo Pieralisi wrote: > > On Mon, Oct 04, 2021 at 04:05:52PM +0100, Marc Zyngier wrote: > > The Apple PCIe controller driver allocates interrupts generated > > by the PCIe ports, and uses irq_domain_alloc_irqs() for that. > > THis is an inline function that uses __irq_domain_alloc_irqs() > > as a backend. > > > > Since the driver can be built as a module, __irq_domain_alloc_irqs() > > must be exported. > > > > Fixes: 201adeaa9d82 ("PCI: apple: Add INTx and per-port interrupt support") > > I have squashed this patch into the commit it is fixing and pushed > pci/apple out. > > I could have merged it as a standalone patch before the commit it is > fixing but it would not make sense on its own I believe, happy to > rectify the branch in case that's preferred. The final patch has links to both patches on the list, so that's absolutely fine by me. Thanks, M. -- Without deviation from the norm, progress is not possible.