From: Jonathan Corbet <corbet@lwn.net>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH] docs: Add more message type documentations for checkpatch
Date: Thu, 20 May 2021 14:45:46 -0600 [thread overview]
Message-ID: <87y2c9m8w5.fsf@meer.lwn.net> (raw)
In-Reply-To: <CABJPP5D=Z6Uwr5hihB1yHjxcww=QO8Ju46m1eruRTuJkKWDXpw@mail.gmail.com>
Dwaipayan Ray <dwaipayanray1@gmail.com> writes:
> (Adding Joe for comments)
>
>> We really shouldn't be linking to outside sites - even kernel.org - when
>> referring to the kernel docs themselves. Just say
>> "Documentation/timers/timers-howto" and let the build system handle the
>> links.
>>
>> There's a lot of these in this file, alas...
>>
>> I've applied this patch since it makes things better overall, but I
>> would really like to see all those URLs go away if possible.
>>
>
> Thanks Jonathan.
>
> Yes it might make things better for the documentation, but again
> since we are using these descriptions in checkpatch's --verbose mode,
> we shall lose the ability to show the links there which I think is currently
> a good addition for the end user.
>
> And I don't think there will be a way to generate these links in checkpatch
> without sphinx's build system....
Ah, OK, I wasn't thinking about that aspect of things; that does change
the situation a bit.
It wouldn't be that hard to do an equivalent of the automarkup magic in
checkpatch to create the relevant links, but I'm not so set on this as
to try to require that. The links can be as they are, sorry for the
noise.
Thanks,
jon
prev parent reply other threads:[~2021-05-20 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 13:23 [PATCH] docs: Add more message type documentations for checkpatch Dwaipayan Ray
2021-05-17 10:04 ` Lukas Bulwahn
2021-05-20 20:13 ` Jonathan Corbet
2021-05-20 20:33 ` Dwaipayan Ray
2021-05-20 20:45 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2c9m8w5.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox