Re: [PATCH 1/3] binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf

Christian Brauner
2020-04-07T16:11:11Z

On Mon, Apr 06, 2020 at 08:31:25PM -0500, Eric W. Biederman wrote:
>
> In 2016 Linus moved install_exec_creds immediately after
> setup_new_exec, in binfmt_elf as a cleanup and as part of closing a
> potential information leak.
>
> Perform the same cleanup for the other binary formats.
>
> Different binary formats doing the same things the same way makes exec
> easier to reason about and easier to maintain.
>
> Putting install_exec_creds immediate after setup_new_exec makes many
> simplifications possible in the code.
>
> Ref: 9f834ec18def ("binfmt_elf: switch to new creds when switching to new mm")
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Sure, why not.
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>