Re: [RFC][PATCH 0/3] exec_update_mutex related cleanups

Christian Brauner
2020-04-07T16:22:18Z

On Mon, Apr 06, 2020 at 08:29:50PM -0500, Eric W. Biederman wrote:
>
> Linus,
>
> Since you rightly pointed out the code in fs/exec.c is less readable
> than it should be right now. Here is where I currently sit on making
> that code static where possible and as obvious as possible.
>
> I will resend this after the merge window for a proper review when
> people are less likely to be distrcacted but I figured I might as well
> send this out now so I can see if anyone runs screaming from this code.
>
> Eric W. Biederman (3):
> binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
> exec: Make unlocking exec_update_mutex explict
> exec: Rename the flag called_exec_mmap point_of_no_return

Under the assumption that we go forward with this approach this seems
like a good cleanup.

Acked-by: Christian Brauner <christian.brauner@ubuntu.com>