Re: [PATCH -V2] mm: Add PageLayzyFree() helper functions for MADV_FREE

David Rientjes
2020-03-06T20:41:37Z

On Thu, 5 Mar 2020, Huang, Ying wrote:

> > In general, I don't think this patch really improves the situation ...
> > it's only a handful of places where this change slightly makes the code
> > easier to understand. And there, only slightly ... I'd prefer better
> > comments instead (e.g., in PageAnon()), documenting what it means for a
> > anon page to either have PageSwapBacked() set or not.
>
> Personally, I still prefer the better named functions than the comments
> here and there. But I can understand that people may have different
> flavor.
>

Maybe add a comment to page-flags.h referring to what PageSwapBacked
indicates when PageAnon is true?