Re: [PATCH -V2] mm: Add PageLayzyFree() helper functions for MADV_FREE

David Rientjes
2020-03-04T20:45:31Z

On Wed, 4 Mar 2020, David Hildenbrand wrote:

> In general, I don't think this patch really improves the situation ...
> it's only a handful of places where this change slightly makes the code
> easier to understand. And there, only slightly ... I'd prefer better
> comments instead (e.g., in PageAnon()), documenting what it means for a
> anon page to either have PageSwapBacked() set or not.
>

Agreed, I think any changes to clarify what PageSwapBacked means when it's
set and when it's clear for PageAnon should be in the form of a comment,
likely in page-flags.h. That's currently lacking for lazy free pages.