From: Michael Ellerman <mpe@ellerman.id.au>
To: Eric Dumazet <edumazet@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] powerpc: add const qual to local_read() parameter
Date: Tue, 12 Nov 2019 10:38:56 +1100 [thread overview]
Message-ID: <87y2wm2dbj.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20191108141353.193961-1-edumazet@google.com>
Eric Dumazet <edumazet@google.com> writes:
> A patch in net-next triggered a compile error on powerpc.
Would be nice to mention the compiler error, I haven't seen the report.
> This seems reasonable to relax powerpc local_read() requirements.
Seems fine.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Dave can you please put this in net-next to limit the window of
breakage.
cheers
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: linuxppc-dev@lists.ozlabs.org
Seems it didn't actually get cc'ed to linuxppc-dev for some reason.
> ---
> arch/powerpc/include/asm/local.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
> index fdd00939270bf08113b537a090d6a6e34a048361..bc4bd19b7fc235b80ec1132f44409b6fe1057975 100644
> --- a/arch/powerpc/include/asm/local.h
> +++ b/arch/powerpc/include/asm/local.h
> @@ -17,7 +17,7 @@ typedef struct
>
> #define LOCAL_INIT(i) { (i) }
>
> -static __inline__ long local_read(local_t *l)
> +static __inline__ long local_read(const local_t *l)
> {
> return READ_ONCE(l->v);
> }
> --
> 2.24.0.432.g9d3f5f5b63-goog
prev parent reply other threads:[~2019-11-11 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 14:13 [PATCH] powerpc: add const qual to local_read() parameter Eric Dumazet
2019-11-11 23:38 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2wm2dbj.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox