RE: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush_pcpu{,ex} definitions to common header

KY Srinivasan
2018-05-17T19:33:49Z

> -----Original Message-----
> From: Vitaly Kuznetsov <vkuznets@redhat.com>
> Sent: Thursday, May 17, 2018 12:06 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: kvm@vger.kernel.org; x86@kernel.org; Paolo Bonzini
> <pbonzini@redhat.com>; Radim Krčmář <rkrcmar@redhat.com>; Roman
> Kagan <rkagan@virtuozzo.com>; Haiyang Zhang <haiyangz@microsoft.com>;
> Stephen Hemminger <sthemmin@microsoft.com>; Michael Kelley (EOSG)
> <Michael.H.Kelley@microsoft.com>; Mohammed Gamal
> <mmorsy@redhat.com>; Cathy Avery <cavery@redhat.com>; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush_pcpu{,ex}
> definitions to common header
>
> KY Srinivasan <kys@microsoft.com> writes:
>
> >> -----Original Message-----
> >> From: Vitaly Kuznetsov <vkuznets@redhat.com>
> >> Sent: Wednesday, May 16, 2018 8:21 AM
> >> To: kvm@vger.kernel.org
> >> Cc: x86@kernel.org; Paolo Bonzini <pbonzini@redhat.com>; Radim
> Krčmář
> >> <rkrcmar@redhat.com>; Roman Kagan <rkagan@virtuozzo.com>; KY
> >> Srinivasan <kys@microsoft.com>; Haiyang Zhang
> >> <haiyangz@microsoft.com>; Stephen Hemminger
> >> <sthemmin@microsoft.com>; Michael Kelley (EOSG)
> >> <Michael.H.Kelley@microsoft.com>; Mohammed Gamal
> >> <mmorsy@redhat.com>; Cathy Avery <cavery@redhat.com>; linux-
> >> kernel@vger.kernel.org
> >> Subject: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush_pcpu{,ex}
> >> definitions to common header
> >>
> >> Hyper-V TLB flush hypercalls definitions will be required for KVM so move
> >> them hyperv-tlfs.h. Structures also need to be renamed as '_pcpu' suffix
> is
> >> irrelevant for a general-purpose definition.
> >>
> >> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> >> ---
> >> arch/x86/hyperv/mmu.c | 40 ++++++++++----------------------------
> >> arch/x86/include/asm/hyperv-tlfs.h | 20 +++++++++++++++++++
> >> 2 files changed, 30 insertions(+), 30 deletions(-)
> >
> > Vitaly,
> >
> > We should coordinate on this; I have patches in flight that conflict with
> > the changes here.
>
> I see you also fixed 'HV_GENERIC_SET_SPARCE_4K' typo. I don't think it's
> a big deal as we fix it in the same way :-)
>
> I see you also altered hv_flush_pcpu_ex definition but kept it in mmu.c:
> I think my patches should be applied on top of yours, I only need to
> move it to hyperv-tlfs.h header and get rid of _pcpu suffix.
>
> I hope Thomas will merge your patches very soon. In case Paolo/Radim
> decide that my series is ready too we'll ask their guidance on how to
> resolve the conflict (topic branch?). It should be relatively easy.

I agree; waiting for Thomas to merge.

K. Y
>
> Thanks,
>
> --
> Vitaly