From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Christophe LEROY <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Scott Wood <oss@buserror.net>,
Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address
Date: Wed, 17 Jan 2018 10:53:41 +0530 [thread overview]
Message-ID: <87y3kxrrc2.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <7341aef1-f2ac-6e9b-8279-93b0f0649b81@c-s.fr>
Christophe LEROY <christophe.leroy@c-s.fr> writes:
>>
>>> How should I split in separate patches ? Something like ?
>>> 1/ Slice support for PPC32 > 2/ Activate slice for 8xx
>>
>> Yes something like that. Will you be able to avoid that
>> if (SLICE_NUM_HIGH) from the code? That makes the code ugly. Right now
>> i don't have definite suggestion on what we could do though.
>>
>
> Could use #ifdefs instead, but in my mind it would be even more ugly.
>
> I would have liked just doing nothing, but the issue is that at the
> moment bitmap_xxx() functions are not prepared to handle bitmaps of size
> zero. Should we try to change that ? Any chance to succeed ?
>
How much code duplication it is to do slice_32.c?
Michael,
What do you suggest here?
-aneesh
next prev parent reply other threads:[~2018-01-17 5:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 16:44 [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address Christophe Leroy
2018-01-05 16:44 ` [PATCH 2/3] powerpc/mm: Allow more than 16 low slices Christophe Leroy
2018-01-16 15:52 ` Aneesh Kumar K.V
2018-01-16 16:37 ` Christophe LEROY
2018-01-05 16:44 ` [PATCH 3/3] powerpc/8xx: Increase the number of mm slices Christophe Leroy
2018-01-16 15:53 ` Aneesh Kumar K.V
2018-01-16 16:16 ` Christophe LEROY
2018-01-16 15:49 ` [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address Aneesh Kumar K.V
2018-01-16 16:31 ` Christophe LEROY
2018-01-16 16:41 ` Aneesh Kumar K.V
2018-01-16 16:57 ` Christophe LEROY
2018-01-17 5:23 ` Aneesh Kumar K.V [this message]
2018-01-17 9:47 ` Christophe LEROY
2018-01-16 16:43 ` Aneesh Kumar K.V
2018-01-16 16:53 ` Christophe LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3kxrrc2.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox