From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753202AbcEZJr5 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 May 2016 05:47:57 -0400
Received: from mga01.intel.com ([192.55.52.88]:25741 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751128AbcEZJrz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 May 2016 05:47:55 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; 
   d="asc'?scan'208";a="709187979"
From: Felipe Balbi <balbi@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Greg KH <gregkh@linuxfoundation.org>, Mark Brown <broonie@kernel.org>,
        USB <linux-usb@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type
In-Reply-To: <CAMz4ku+tcaDT0MYAL2oyCbjAHUBKoy-_5ZE8LxvqkGTc1kq2LQ@mail.gmail.com>
References: <7eb2c730f54f117438b6111bb63799a5d8c7249c.1464238593.git.baolin.wang@linaro.org> <87eg8pqqwx.fsf@linux.intel.com> <CAMz4kuJti6uXY6988xu-CWOr7H5hhO_=juz84LQEqLG7uFwegQ@mail.gmail.com> <8760u1qmxl.fsf@linux.intel.com> <CAMz4ku+tcaDT0MYAL2oyCbjAHUBKoy-_5ZE8LxvqkGTc1kq2LQ@mail.gmail.com>
User-Agent: Notmuch/0.22+11~g124a67e (http://notmuchmail.org) Emacs/25.0.93.2 (x86_64-pc-linux-gnu)
Date: Thu, 26 May 2016 12:45:24 +0300
Message-ID: <87y46xp2yz.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Baolin Wang <baolin.wang@linaro.org> writes:

<trim>

>> Also note that the usb_endpoint_xfer_isoc() call on line 2067 of
>> gadget.c (as in my testing/next from today) won't even get executed, so
>> we're safe there.
>
> Never will be executed? then we can remove the
> usb_endpoint_xfer_isoc() (line 2025) at risk?
>
> 2023         clean_busy =3D dwc3_cleanup_done_reqs(dwc, dep, event, statu=
s);
> 2024         if (clean_busy && (is_xfer_complete ||
> 2025
> usb_endpoint_xfer_isoc(dep->endpoint.desc)))
> 2026                 dep->flags &=3D ~DWC3_EP_BUSY;

hmm, now that I look at this again, in case of XferInProgress, we could
still have a problem.

I'll fix it up in that commit I pointed you to.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXRsW0AAoJEIaOsuA1yqRET2oP/RKDkHA4Xpp6Jqs68RvS+zWV
6bOKp4pbpkjsEJ6mPBriVSL1QFFeVZ9cqRtG4U93fPRAOWOrPtsi5p/qrMUGY1ex
IJa1Lgx+1fQnXgHAU+7+O+YUGr5R12eLIGGT/MOc5buZ1RQocfxZ8Urm1r5muKbI
LYYk6grbL2yjy/QyP19EFUfgDRB8ifZiMPnyer9eoIwNfh1rZMY0b6O3/5wJMTIJ
K2Zuy2Um43ZJyqAczwuMwDsR8aqxuW8R82NnBD9ZRpIYoMI359nlBSl3HzA5hlbe
ANsFLHPXYgRyRh43p1+IQRMKpc+9HEL3bN6iZihgAtqC7/Ejd2VCEmVZGkd25ECG
n2BPHTYefacL6ooXa1CsRsxwD8bfa9KYS7pMBzIQ8WG3CQyl/Dg71LGVCwV0Qc9z
k195EHNNDrya+8tMfvbM/62DLrj38MzLdb4+aW+3Q2RmZl147nR5WG1RJ7O2gGYO
waqwK+HZA91E1quZhmaorFtIjMM5M8EVH0lmJBGK+ZIEzJh5L3f7PwZmoDmC1nUO
zCyq+9rDDaOZvU0cN3vurq8c7O+OWA4O5kAr7KfZwk1HWGQGhoMlRTqq2qwXaPqh
B1tquHFjXvEZ51b2SvDslM72O3Fmu9hCdCIZiD7GckK+4L0MGz9WMviBMBy2tap3
5ktwypa26pDlMBSaByMU
=Bq4Y
-----END PGP SIGNATURE-----
--=-=-=--