From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932141AbcEKS0V (ORCPT ); Wed, 11 May 2016 14:26:21 -0400 Received: from mx0.mattleach.net ([176.58.118.143]:36264 "EHLO mx0.mattleach.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbcEKS0T (ORCPT ); Wed, 11 May 2016 14:26:19 -0400 X-Greylist: delayed 463 seconds by postgrey-1.27 at vger.kernel.org; Wed, 11 May 2016 14:26:18 EDT From: Matthew Leach To: Krzysztof Kozlowski Cc: Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board In-Reply-To: <1462950412-16681-1-git-send-email-k.kozlowski@samsung.com> (Krzysztof Kozlowski's message of "Wed, 11 May 2016 09:06:52 +0200") References: <1462950412-16681-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Date: Wed, 11 May 2016 19:18:31 +0100 Message-ID: <87y47gwj9k.fsf@mattleach.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, Sorry for not acting on the feedback sooner - I lost the email in my Inbox! I've tested the patch on my Origen board and it works fine. One small comment in-line. Krzysztof Kozlowski writes: > From: Matthew Leach > > Enable the Origen's usb phy and ohci devices in the device tree. Also > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so > the AX88760 hub is powered. > > Signed-off-by: Matthew Leach > [k.kozlowski: Extend nodes by label notation instead of path] > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts > index 8bca699b7f20..4c59bdb0e6f3 100644 > --- a/arch/arm/boot/dts/exynos4412-origen.dts > +++ b/arch/arm/boot/dts/exynos4412-origen.dts > @@ -77,12 +77,29 @@ > clock-frequency = <24000000>; > }; > }; > + I think we could loose this line break? Thanks, -- Matt