From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756329AbcECT3p (ORCPT ); Tue, 3 May 2016 15:29:45 -0400 Received: from smtp12.smtpout.orange.fr ([80.12.242.134]:33401 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbcECT3n (ORCPT ); Tue, 3 May 2016 15:29:43 -0400 X-Greylist: delayed 451 seconds by postgrey-1.27 at vger.kernel.org; Tue, 03 May 2016 15:29:43 EDT X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 03 May 2016 21:22:10 +0200 X-ME-IP: 109.220.176.123 From: Robert Jarzmik To: Mark Brown Cc: Daniel Mack , Haojian Zhuang , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com Subject: Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers References: <1462050939-27940-1-git-send-email-robert.jarzmik@free.fr> <1462050939-27940-2-git-send-email-robert.jarzmik@free.fr> <20160503115159.GP6292@sirena.org.uk> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 03 May 2016 21:22:05 +0200 In-Reply-To: <20160503115159.GP6292@sirena.org.uk> (Mark Brown's message of "Tue, 3 May 2016 12:51:59 +0100") Message-ID: <87y47roski.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Brown writes: > On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: >> Split out from the ac97_codec.h the ac97 generic registers, which can be >> used by a codec, typically a generic ac97 codec, and by the ac97 bus, to >> scan an ac97 AC-Link. > > I don't entirely see the value in this one but equally it does no harm. Oh that's to have the defines AC97_VENDOR_ID1 and AC97_VENDOR_ID2, but without including ac97_codec.h in sound/ac97/bus.c. Cheers. -- Robert