Re: [PATCH 0/2] memory_hotplug: introduce config and command line options to set the default onlining policy

Vitaly Kuznetsov
2016-04-07T08:42:58Z

Andrew Morton <akpm@linux-foundation.org> writes:

> On Wed, 6 Apr 2016 15:45:10 +0200 Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
>> This patchset continues the work I started with:
>>
>> commit 31bc3858ea3ebcc3157b3f5f0e624c5962f5a7a6
>> Author: Vitaly Kuznetsov <vkuznets@redhat.com>
>> Date: Tue Mar 15 14:56:48 2016 -0700
>>
>> memory-hotplug: add automatic onlining policy for the newly added memory
>>
>> Initially I was going to stop there and bring the policy setting logic to
>> userspace. I met two issues on this way:
>>
>> 1) It is possible to have memory hotplugged at boot (e.g. with QEMU). These
>> blocks stay offlined if we turn the onlining policy on by userspace.
>>
>> 2) My attempt to bring this policy setting to systemd failed, systemd
>> maintainers suggest to change the default in kernel or ... to use tmpfiles.d
>> to alter the policy (which looks like a hack to me):
>> https://github.com/systemd/systemd/pull/2938
>
> That discussion really didn't come to a conclusion and I don't
> understand why you consider Lennert's "recommended way" to be a hack?

Just the name. To me 'tmpfiles.d' doesn't sound like an appropriate
place to search for kernel tunables settings. It would be much better in
case we had something like 'tunables.d' for that.

--
Vitaly