From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754997AbbK0Q3X (ORCPT ); Fri, 27 Nov 2015 11:29:23 -0500 Received: from down.free-electrons.com ([37.187.137.238]:33902 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754792AbbK0Q3U (ORCPT ); Fri, 27 Nov 2015 11:29:20 -0500 From: Gregory CLEMENT To: Marcin Wojtas Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, davem@davemloft.net, linux@arm.linux.org.uk, sebastian.hesselbarth@gmail.com, andrew@lunn.ch, jason@lakedaemon.net, thomas.petazzoni@free-electrons.com, simon.guinot@sequanux.org, nadavh@marvell.com, alior@marvell.com, xswang@marvell.com, myair@marvell.com, nitroshift@yahoo.com, jaz@semihalf.com, tn@semihalf.com Subject: Re: [PATCH v3 net 6/6] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0 References: <1448639066-13074-1-git-send-email-mw@semihalf.com> <1448639066-13074-7-git-send-email-mw@semihalf.com> Date: Fri, 27 Nov 2015 17:29:18 +0100 In-Reply-To: <1448639066-13074-7-git-send-email-mw@semihalf.com> (Marcin Wojtas's message of "Fri, 27 Nov 2015 16:44:26 +0100") Message-ID: <87y4dj76e9.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marcin, On ven., nov. 27 2015, Marcin Wojtas wrote: > The Ethernet controller found in the Armada 38x SoC's family support > TCP/IP checksumming with frame sizes larger than 1600 bytes, however > only on port 0. > > This commit enables it by setting 'tx-csum-limit' to 9800B in > 'ethernet@70000' node. > > Signed-off-by: Marcin Wojtas > --- > arch/arm/boot/dts/armada-38x.dtsi | 1 + This commit should not be merged through the network subsystem but through mvebu and then arm-soc. Indeed we tried to centralize all the dts change in only one subsystem to reduce the merge conflict. Could you rename it in "mvebu: dts: enable IP checksum with jumbo frames for Armada 38x on Port0" ? I will applied on in mvebu/dts as soon as the network part will be applied. Thanks, Gregory > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index c6a0e9d..e8b7f67 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -498,6 +498,7 @@ > reg = <0x70000 0x4000>; > interrupts-extended = <&mpic 8>; > clocks = <&gateclk 4>; > + tx-csum-limit = <9800>; > status = "disabled"; > }; > > -- > 1.8.3.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com