From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045AbbJZSJF (ORCPT ); Mon, 26 Oct 2015 14:09:05 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:37765 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbbJZSJD (ORCPT ); Mon, 26 Oct 2015 14:09:03 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 26 Oct 2015 19:09:02 +0100 X-ME-IP: 109.220.216.95 From: Robert Jarzmik To: Lars-Peter Clausen Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap References: <1445722627-28854-1-git-send-email-robert.jarzmik@free.fr> <562E0E18.80500@metafoo.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 26 Oct 2015 19:02:32 +0100 In-Reply-To: <562E0E18.80500@metafoo.de> (Lars-Peter Clausen's message of "Mon, 26 Oct 2015 12:27:20 +0100") Message-ID: <87y4epjyo7.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lars-Peter Clausen writes: > On 10/24/2015 11:37 PM, Robert Jarzmik wrote: > [...] >> -static unsigned int ac97_read(struct snd_soc_codec *codec, >> - unsigned int reg); >> -static int ac97_write(struct snd_soc_codec *codec, >> - unsigned int reg, unsigned int val); > > For review purposes it would be helpful to split this into two patches. One > performing the regmap conversion the other replacing > ac97_read()/ac97_write() with the matching snd_soc_ calls (or > snd_soc_update_bits). Most certainly, I'll do that. If bissection is not broken, it's fine by me. >> + snd_soc_codec_init_regmap(codec, regmap); > > You need to call snd_soc_odec_exit_regmap() when the CODEC is unbound. Ah yes, I'll put that in the next iteration, thanks. Cheers. -- Robert