public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: behanw@converseincode.com, khali@linux-fr.org, rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, dwmw2@infradead.org,
	pageexec@freemail.hu, Mark Charlebois <charlebm@gmail.com>,
	Behan Webster <behanw@converseincode.com>
Subject: Re: [PATCH] module: LLVMLinux: Remove unused function warning from __param_check macro
Date: Tue, 11 Mar 2014 16:41:35 +1030	[thread overview]
Message-ID: <87y50hw9go.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1394219327-5591-1-git-send-email-behanw@converseincode.com>

behanw@converseincode.com writes:
> From: Mark Charlebois <charlebm@gmail.com>
>
> This code makes a compile time type check that is optimized away. Clang
> complains that it generates an unused function.
>
> I believe GCC won't complain for a static inline fuction but would if it
> was just a static function.
>
> Adding the unused attribute to the function declaration removes the warning.
>
> This code works for both gcc and clang.
>
> Signed-off-by: Mark Charlebois <charlebm@gmail.com>
> Signed-off-by: Behan Webster <behanw@converseincode.com>

Please include the actual warning clang spits out.  That helps because
(1) I know what you're referring to, and
(2) it helps others if they are later googling for the error.

I don't have any huge objections to this patch (__always_unused) though.

Thanks,
Rusty.

  parent reply	other threads:[~2014-03-11  6:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 19:08 [PATCH] module: LLVMLinux: Remove unused function warning from __param_check macro behanw
2014-03-07 22:56 ` PaX Team
2014-03-08  0:52   ` Behan Webster
2014-03-08  1:25     ` PaX Team
2014-03-08  1:35       ` Stephen Boyd
2014-03-08  2:10         ` [PATCH v2] " behanw
2014-03-08  2:17           ` Joe Perches
2014-03-08  2:21             ` Behan Webster
2014-03-11  6:11 ` Rusty Russell [this message]
2014-03-11  7:00   ` [PATCH] " Behan Webster
2014-03-11 21:24   ` [PATCH v3] " behanw
2014-03-17  2:47     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y50hw9go.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=behanw@converseincode.com \
    --cc=charlebm@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pageexec@freemail.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox