From: Andi Kleen <andi@firstfloor.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Waiman Long <waiman.long@hp.com>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"Chandramouleeswaran\, Aswin" <aswin@hp.com>, "Norton\,
Scott J" <scott.norton@hp.com>,
George Spelvin <linux@horizon.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: Avoiding the dentry d_lock on final dput(), part deux: transactional memory
Date: Wed, 02 Oct 2013 07:56:50 -0700 [thread overview]
Message-ID: <87y56boh59.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <CA+55aFw6tOVMw=pKE_knj4BOwTi_JAX=4N=-5_WduykNPotdww@mail.gmail.com> (Linus Torvalds's message of "Mon, 30 Sep 2013 13:04:34 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Mon, Sep 30, 2013 at 1:01 PM, Waiman Long <waiman.long@hp.com> wrote:
>>
>> I think this patch is worth a trial if relevant hardware is more widely
>> available. The TSX code certainly need to be moved to an architecture
>> specific area and should be runtime enabled using a static key. We also need
>> more TSX support infrastructure in place first.
>
> I think we can pick that up from Andi's patches, he should have that.
> Although that did have very x86-specific naming (ie "xbegin"). And I
> don't think he used "asm goto" to quite the same advantage as this -
> and I think we do want to make sure that the overhead is minimal.
FWIW my version #0 used asm goto directly, but I later switched to not
using it to support more compilers and higher level abstractions (locks
etc.) and use the same intrinsics as the user level guys are using.
The two extra instructions from not using asm goto for xbegin
don't matter all that much in the end.
That's the old asm goto stuff I wrote originally
(user level version):
https://github.com/andikleen/tsx-tools/blob/master/include/rtm-goto.h
There was also a kernel version of it that patched, right
now this is done in the main TSX patchkit like this:
https://git.kernel.org/cgit/linux/kernel/git/ak/linux-misc.git/commit/?h=hle312/rtm-base&id=9190346d57a9bc89e746aee774d07e54cd1e6e75
Essentially without RTM it just becomes and unconditional jump
to the abort handler, xabort is a nop, and xtest always returns 0.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2013-10-02 14:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 19:29 Avoiding the dentry d_lock on final dput(), part deux: transactional memory Linus Torvalds
2013-09-30 20:01 ` Waiman Long
2013-09-30 20:04 ` Linus Torvalds
2013-10-02 14:56 ` Andi Kleen [this message]
2013-09-30 22:52 ` Benjamin Herrenschmidt
2013-10-01 0:36 ` Michael Neuling
2013-10-01 0:56 ` Linus Torvalds
2013-10-01 2:05 ` Benjamin Herrenschmidt
2013-10-01 3:13 ` Paul E. McKenney
2013-10-01 4:52 ` Michael Neuling
2013-10-01 12:16 ` Paul E. McKenney
2013-10-01 13:42 ` Paul E. McKenney
2013-10-01 1:05 ` spinlock contention of files->file_lock Eric Dumazet
2013-10-01 1:44 ` Linus Torvalds
2013-10-01 2:18 ` Eric Dumazet
2013-10-01 21:41 ` Eric Dumazet
2013-10-01 22:04 ` Al Viro
2013-10-01 22:21 ` Eric Dumazet
2013-10-02 5:13 ` Ingo Molnar
2013-10-02 10:20 ` Al Viro
2013-10-02 10:56 ` Ingo Molnar
2013-10-01 1:53 ` Al Viro
2013-10-01 2:02 ` Linus Torvalds
2013-10-01 3:27 ` Al Viro
2013-10-01 3:36 ` Eric Dumazet
2013-10-01 5:12 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y56boh59.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=aswin@hp.com \
--cc=benh@kernel.crashing.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=scott.norton@hp.com \
--cc=torvalds@linux-foundation.org \
--cc=waiman.long@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox