From: Namhyung Kim <namhyung@kernel.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: acme@infradead.org, <linux-kernel@vger.kernel.org>,
feng.tang@intel.com, namhyung.kim@lge.com
Subject: Re: [PATCH 1/2] perf annotate: Fix build with NO_NEWT=1
Date: Tue, 26 Feb 2013 18:02:43 +0900 [thread overview]
Message-ID: <87y5ebsb0s.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1361854923-1814-1-git-send-email-michael@ellerman.id.au> (Michael Ellerman's message of "Tue, 26 Feb 2013 16:02:02 +1100")
Hi Michael,
On Tue, 26 Feb 2013 16:02:02 +1100, Michael Ellerman wrote:
> Commit 18c9e5c "Make it to be able to skip unannotatable symbols" broke
> the build with NO_NEWT=1:
>
> CC builtin-annotate.o
> builtin-annotate.c: In function 'hists__find_annotations':
> builtin-annotate.c:161:4: error: duplicate case value
> builtin-annotate.c:154:4: error: previously used here
> make: *** [builtin-annotate.o] Error 1
>
> This is because without NEWT support K_LEFT is #defined to -1 in
> utils/hist.h
>
> Fix it by shifting the K_LEFT/K_RIGHT #defines out of the likely range
> of error values.
Argh, didn't check NO_NEWT build on this, sorry.
The hist_entry__tui_annotate() - hence, symbol__tui_annotate() - returns
either key code or error code. This is not good IMHO but not sure it's
worth refactoring. Maybe we can move the error check to under default
case so that possible future error checks to be done?
Thanks,
Namhyung
next prev parent reply other threads:[~2013-02-26 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 5:02 [PATCH 1/2] perf annotate: Fix build with NO_NEWT=1 Michael Ellerman
2013-02-26 5:02 ` [PATCH 2/2] perf report: " Michael Ellerman
2013-02-26 8:48 ` Feng Tang
2013-02-26 11:46 ` Michael Ellerman
2013-03-18 10:51 ` [tip:perf/urgent] " tip-bot for Michael Ellerman
2013-02-26 9:02 ` Namhyung Kim [this message]
2013-02-27 1:14 ` [PATCH 1/2] perf annotate: " li guang
2013-02-27 1:22 ` Michael Ellerman
2013-02-27 1:29 ` li guang
2013-02-27 1:29 ` li guang
2013-02-27 2:31 ` Namhyung Kim
2013-03-18 10:50 ` [tip:perf/urgent] " tip-bot for Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5ebsb0s.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=acme@infradead.org \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox