From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753259Ab0CUTKv (ORCPT ); Sun, 21 Mar 2010 15:10:51 -0400 Received: from one.firstfloor.org ([213.235.205.2]:55195 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509Ab0CUTKt (ORCPT ); Sun, 21 Mar 2010 15:10:49 -0400 To: Ben Hutchings Cc: Jesse Barnes , David Woodhouse , linux-pci@vger.kernel.org, LKML , linux-parisc@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 2/4] panic: Allow taint flag for warnings to be changed from TAINT_WARN From: Andi Kleen References: <1269126097.18314.111.camel@localhost> <1269126340.18314.115.camel@localhost> Date: Sun, 21 Mar 2010 20:10:43 +0100 In-Reply-To: <1269126340.18314.115.camel@localhost> (Ben Hutchings's message of "Sat, 20 Mar 2010 23:05:40 +0000") Message-ID: <87y6hlebik.fsf@basil.nowhere.org> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ben Hutchings writes: > WARN() is used in some places to report firmware or hardware bugs that > are then worked-around. These bugs do not affect the stability of the > kernel and should not set the usual TAINT_WARN flag. To allow for > this, add WARN_TAINT() and WARN_TAINT_ONCE() macros that take a taint > flag as argument. > > Architectures that implement warnings using trap instructions instead > of calls to warn_slowpath_*() must now implement __WARN_TAINT(taint) > instead of __WARN(). I guess this should enforce that at least some taint flag is set? (e.g. with a BUILD_BUG_ON) -Andi -- ak@linux.intel.com -- Speaking for myself only.