public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ppc32: Re-add embed_config.c to ml300/ep405
@ 2006-01-04 22:24 Peter Korsgaard
  2006-01-06 22:36 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2006-01-04 22:24 UTC (permalink / raw)
  To: linux-kernel, mporter, akpm

Hi,

Commit 3e9e7c1d0b7a36fb8affb973a054c5098e27baa8 (ppc32: cleanup AMCC
PPC40x eval boards to support U-Boot) broke the kernel for ML300 /
EP405.

It still compiles as there's a weak definition of the function in
misc-embedded.c, but the kernel crashes as the bd_t fixup isn't
performed.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>

diff -urpN linux-2.6.15.orig/arch/ppc/boot/simple/Makefile linux-2.6.15/arch/ppc/boot/simple/Makefile
--- linux-2.6.15.orig/arch/ppc/boot/simple/Makefile	2006-01-03 12:04:08.000000000 +0100
+++ linux-2.6.15/arch/ppc/boot/simple/Makefile	2006-01-04 15:08:46.000000000 +0100
@@ -190,6 +190,8 @@ boot-$(CONFIG_REDWOOD_5)	+= embed_config
 boot-$(CONFIG_REDWOOD_6)	+= embed_config.o
 boot-$(CONFIG_8xx)		+= embed_config.o
 boot-$(CONFIG_8260)		+= embed_config.o
+boot-$(CONFIG_EP405)		+= embed_config.o
+boot-$(CONFIG_XILINX_ML300)	+= embed_config.o
 boot-$(CONFIG_BSEIP)		+= iic.o
 boot-$(CONFIG_MBX)		+= iic.o pci.o qspan_pci.o
 boot-$(CONFIG_MV64X60)		+= misc-mv64x60.o


-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ppc32: Re-add embed_config.c to ml300/ep405
  2006-01-04 22:24 [PATCH] ppc32: Re-add embed_config.c to ml300/ep405 Peter Korsgaard
@ 2006-01-06 22:36 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2006-01-06 22:36 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: linux-kernel, mporter, akpm

On Wed, Jan 04, 2006 at 11:24:32PM +0100, Peter Korsgaard wrote:

> Hi,
> 
> Commit 3e9e7c1d0b7a36fb8affb973a054c5098e27baa8 (ppc32: cleanup AMCC
> PPC40x eval boards to support U-Boot) broke the kernel for ML300 /
> EP405.
> 
> It still compiles as there's a weak definition of the function in
> misc-embedded.c, but the kernel crashes as the bd_t fixup isn't
> performed.
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>

I've seen this from others as well,
Acked-by: Tom Rini <trini@kernel.crashing.org>

... and this should goto stable@ once in Linus' tree.

> diff -urpN linux-2.6.15.orig/arch/ppc/boot/simple/Makefile linux-2.6.15/arch/ppc/boot/simple/Makefile
> --- linux-2.6.15.orig/arch/ppc/boot/simple/Makefile	2006-01-03 12:04:08.000000000 +0100
> +++ linux-2.6.15/arch/ppc/boot/simple/Makefile	2006-01-04 15:08:46.000000000 +0100
> @@ -190,6 +190,8 @@ boot-$(CONFIG_REDWOOD_5)	+= embed_config
>  boot-$(CONFIG_REDWOOD_6)	+= embed_config.o
>  boot-$(CONFIG_8xx)		+= embed_config.o
>  boot-$(CONFIG_8260)		+= embed_config.o
> +boot-$(CONFIG_EP405)		+= embed_config.o
> +boot-$(CONFIG_XILINX_ML300)	+= embed_config.o
>  boot-$(CONFIG_BSEIP)		+= iic.o
>  boot-$(CONFIG_MBX)		+= iic.o pci.o qspan_pci.o
>  boot-$(CONFIG_MV64X60)		+= misc-mv64x60.o

-- 
Tom Rini
http://gate.crashing.org/~trini/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-06 22:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-04 22:24 [PATCH] ppc32: Re-add embed_config.c to ml300/ep405 Peter Korsgaard
2006-01-06 22:36 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox