From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: cai <junjiec@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][fat] use mpage_readpage when cluster size is page-alignment
Date: Thu, 29 Dec 2005 18:19:02 +0900 [thread overview]
Message-ID: <87y824p8ft.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <43B3844A.5050401@gmail.com> (cai's message of "Thu, 29 Dec 2005 15:38:02 +0900")
cai <junjiec@gmail.com> writes:
>>Can't we use mpage_readpage() always? IIRC, that should work fine
>>without disadvantage.
>>
> it should work, but maybe some performance loses if the
> cluster size is not page-alignment, for example, 4 sector/cluster
> in a 4KB/page system.
> because it will fall back to the block_read_full_page when
> non-adjacent block found in do_mpage_readpage, i think.
> the same applies to mpage_readpages too.
Ah, yes.
But if cluster is not fragmented it shouldn't fall back, and rather it
will get advantage. And I guess, even if it fall back to
block_read_full_page(), it would be very trivial.
What do you think? We may need benchmark...
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2005-12-29 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-28 7:56 [RFC][fat] use mpage_readpage when cluster size is page-alignment junjie cai
[not found] ` <2cd57c900512280040g594ba003y@mail.gmail.com>
2005-12-28 9:36 ` junjie cai
2005-12-28 12:57 ` OGAWA Hirofumi
2005-12-29 6:38 ` cai
2005-12-29 8:06 ` Pekka Enberg
2005-12-29 8:52 ` cai
2005-12-29 9:12 ` Pekka J Enberg
2005-12-29 9:19 ` OGAWA Hirofumi [this message]
2005-12-29 10:24 ` cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y824p8ft.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=junjiec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox