From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6057F18DB1F for ; Tue, 2 Jun 2026 09:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780394309; cv=none; b=QQOCU8dcjH9uIntpiWaCBBwEJqEABgo8r37wv6Gr1TdY3q8LqxFInKnhsNTUTTnOQbQiWCtkGGfF2blig0rY2tbNrqJeJsIyXjTSvuLLTO3LZ4dDmPQ3okyHmrFymu+XLYaGHEm17coMtMUkLTDippd6g2AeX5s1B95kBAK3Zv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780394309; c=relaxed/simple; bh=9KrjWj23ltC/MWJTEE+BQAQd/5TIXPPOwrS3Ii7xAGo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=gRi9GWgxP9ZcSBYGuIqrTUf956qoKQ5R5LMUAupW0uAt7QF8HGgsjmXdBPOVo56B/iFSUzYxfzXOC7Zv2ZyL9yERPjJizDygNnUw9EBqTdF16tioeWdcELBjrrM26GLoEKkNFhawP/iMJ1MyzpFvh2DmmIxKCL1G6DwNQG3+CsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=OlP05TaN; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="OlP05TaN" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 7DC141A37B9; Tue, 2 Jun 2026 09:58:20 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4EE81603BC; Tue, 2 Jun 2026 09:58:20 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 688601088817C; Tue, 2 Jun 2026 11:58:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780394299; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=9KrjWj23ltC/MWJTEE+BQAQd/5TIXPPOwrS3Ii7xAGo=; b=OlP05TaN7Wj0diVNom9buZyXGj2oDSOr5Vdr7eHzdx+TwFIqgu+5MmbayH2MgMIyIQDlXL xfrz9Gr3Z5prCRT7QJxn4FO2avv7J0Y3x7ISen9hpM5lex/AUK4Kt3OeNc0YPVZNlHZ7Xv O4EASZNevTkreCoAIHrpO1QAwP3LSMt7CxzeUrFraLBiFq2hW6/9DLBmhAKyZioXtwGSHW FXEMuIKRzWeKfdmbcJREdLjrPeILAtjsdJvSWwmLw6vIenJJzabCLf1XKbyrKNR5PDU75+ 7fJ1K/Y7cIC5ONSPgx5CBh0MPDIGhr42gRq5Nina5KCYLFTCXu4j8DfVaiRcUw== From: Miquel Raynal To: Michael Walle Cc: Pratyush Yadav , Takahiro Kuwano , Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure In-Reply-To: <20260601125438.3481722-3-mwalle@kernel.org> (Michael Walle's message of "Mon, 1 Jun 2026 14:52:44 +0200") References: <20260601125438.3481722-1-mwalle@kernel.org> <20260601125438.3481722-3-mwalle@kernel.org> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 02 Jun 2026 11:58:17 +0200 Message-ID: <87zf1dmfgm.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Last-TLS-Session-Version: TLSv1.3 On 01/06/2026 at 14:52:44 +02, Michael Walle wrote: > This was introduced in commit 548ed6847f530 ("mtd: spi-nor: Add the > SNOR_F_4B_OPCODES flag"). It looks like it was the rollback mechanism if > parsing the SFDP failed, but was setting that flag first. Nowadays, that > flag can only be set if spi_nor_parse_4bait() was successful. IOW, the > flags won't be left in an undefined state if parsing SFDP fails. > > Remove the unneeded code to be able to rework spi_nor_init_params(). > > Signed-off-by: Michael Walle Reviewed-by: Miquel Raynal