From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 524F23DE44D for ; Wed, 27 May 2026 08:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779870580; cv=none; b=BjZb5yM0MSINvbgM/6TBhT7C2vlfl23wvOOmTkCXcHuQ19zkPMplcfUpyhiKK4VLL/UPg171Xsrze7nbLbSCR0g/FB1Yi8zFFbtCh7Wg0qFy04+mss+SkKHWCqRnE9uZJMQ0+Od4DMinndPr1uo5H5N4fpjy+Eu4r7OUrvydXPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779870580; c=relaxed/simple; bh=AP5wS6BrM6YlHVRtbIzqKXlmcQG2KJQWp75kEYNxoMo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=IKQkqa6L6aXepaR82vkry5aDrkj4lgdqIwFOC0VIWch0B/kYQxUsfXyYV0y/oLRGoMi2Ia7mfiQdUeHJ5sbS6i9hsMKYgWyRD2aMnA4yfrxYLuSFQDe/x5b0UJKMh3oPrCOsHc2Os7cFcxdjMJNaaXZVX0ITzIwLMtxzaGxONjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=g4fYCeJb; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="g4fYCeJb" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 82E484E42D67 for ; Wed, 27 May 2026 08:29:36 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 565C8601A1; Wed, 27 May 2026 08:29:36 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F025810888BA2; Wed, 27 May 2026 10:29:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1779870575; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=CWZgbSks4vt0vDT6Ogk7ELZgoPhWG9xAqtrnA7KlwS8=; b=g4fYCeJby2XbHS6Dy67G2WdkA/EEsKMnySAr6k8VcXV7fowApuwy6+Ahkz7rqguwEg118z TRAlVnjOwW+6blmaWOWSdxSA6molBDJtTgwUsL4Pq5/uzPJ9pWyh1SDLpX9GzgcWw5V3bl 3xl+oLlSwgpyiKas61c2hdrgROxxdYA1K2mFNaN1e3GnPDVa7kIzE9uyczs9RncJwW0I+X 9YUgHiB/F08t4n2QUJknq6k+pBouiSkJC7sQW/cRlQlLxHmPCic62vbC6/rlUMJVjRdtVt j7V39WaHqPtilsk7toTSwTJHkmE7zyLyRyjatT8Md2p1mAryqR7gy2hvLxCsPw== From: Miquel Raynal To: Qing Wu Cc: Michal Simek , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] [v2] mtd: spinand: add support for additional Dosilicon models In-Reply-To: <20260520003733.82514-1-ses1er@gmail.com> (Qing Wu's message of "Tue, 19 May 2026 20:37:33 -0400") References: <20260520003733.82514-1-ses1er@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 27 May 2026 10:29:33 +0200 Message-ID: <87zf1ljlw2.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Qing, On 19/05/2026 at 20:37:33 -04, Qing Wu wrote: Could you please change the title for: "mtd: spinand: dosilicon: Add support for additional models" > Add support for additional Dosilicon SPI NAND chips. > > Datasheets for chips included in this patch: https://www.dosilicon.com/SP= I%20NAND%20Flash.html > > Tested on a TP-Link TL-7DR7250 with a Dosilicon DS35Q1GB (0xE5 0xF1) > > Link to original v2: > https://lore.kernel.org/all/20260217221444.11171-1-ses1er@gmail.com/ This link should be below the three '---'. > Signed-off-by: Qing Wu > --- > Changes in v2: > - Fixed compilation errors. > - Link to v1: https://lore.kernel.org/all/20260217211427.9120-1-ses1er@gm= ail.com > --- > drivers/mtd/nand/spi/dosilicon.c | 203 +++++++++++++++++++++++++++++-- > 1 file changed, 196 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/nand/spi/dosilicon.c b/drivers/mtd/nand/spi/dosi= licon.c > index f99899866ceb..6a5100c6bf99 100644 > --- a/drivers/mtd/nand/spi/dosilicon.c > +++ b/drivers/mtd/nand/spi/dosilicon.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > * Author: Ahmed Naseef > + * Additions: Qing Wu There is Git for that, please drop that line. > +static int ds35xxgb_ooblayout_free(struct mtd_info *mtd, int section, > + struct mtd_oob_region *region) > +{ > + if (section) > + return -ERANGE; > + > + /* Reserve 1 bytes for the BBM. */ > + region->offset =3D 1; Please reserve 2, that is what we have been doing so far. Otherwise lgtm. I can take it for the next merge window if you resend rapidly. Thanks, Miqu=C3=A8l