From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08211366575 for ; Wed, 20 May 2026 09:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779267711; cv=none; b=cxf/sxlUfDBB2Lf4RkRZxRJgHM56sKCk0NZw96AXcnYYVIShTX8C/K3TrEjV4RRfKXAMcKqJeiutKAaTRgCHE7yprGl+cQ6GP0Jz7PtRp8u07JL5u7sOhliF3EB61U60RBjtXRPYSc+QTFr/66EhnV7aFXlkZPxviErC42bHrdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779267711; c=relaxed/simple; bh=wJa0MBQ0x/NpSf2q6zV/HJjThfXApmAOKgyoiM+4FC4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=BBgE1zyf1JHJovR5jJy5IKkh4NoCsMxgx9deP1xfonSJsoN3Yrq6PmBoCEHdxAiZUzxN8SlOlL3P2qghm39ronMHms6lEQ5AGYAkvtZg/9eFkt8+R7JLFdT3/1Xv7QD8ItntEB1UQVJi5E4v5+dU3dTNc/RzzNhezjcA9Kq7mTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jo9sHOiJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jo9sHOiJ" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 1EA031F000E9; Wed, 20 May 2026 09:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779267709; bh=2NUfpVPbc2DDECAWrlqnSBM0fvNgQdWuzspp6uUrzQw=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Jo9sHOiJ4Um3HME0+SrWgogHkjs/x4Ao/uAsTAKp7xRltxig41SSN/Iv7SGThVh+t Iht5FXNU9LLYjN6nwAC/L2ReTqJmtNvYjWMd484G0IJ2T1mvIZDW6mi81TSAeJlvQV qhgVnw3WqgdOEXhXYhi+PQWPg/u6Z7EQM5nY4xQ6OEO4cc98lq//GG/zm2MZ1FJFu/ 4fTPboXq3FFZohxva0fOy3yOIJst1MJbMCXs52OWJc9oa2zJkYZB9p/G8/b8Bzv1tU a5SOPv+beMj+73s7jO/BFXQd9CVbzc5xeyj1Ro/7Gl54Ibvrn6a7kyocWsGLFtwc65 3XkwZCd4hdmFQ== From: Thomas Gleixner To: Rosen Penev Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip/dw-apb-ictl: fix compilation on x86 In-Reply-To: References: <20260519025703.817197-1-rosenp@gmail.com> <8733znxqtd.ffs@tglx> Date: Wed, 20 May 2026 11:01:47 +0200 Message-ID: <87zf1uwj2c.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, May 19 2026 at 14:22, Rosen Penev wrote: > On Tue, May 19, 2026 at 10:16=E2=80=AFAM Thomas Gleixner wrote: >> >> On Mon, May 18 2026 at 19:57, Rosen Penev wrote: >> > __irq_entry belongs nowhere in irqchip drivers as it is an >> > architecture specific annotation. There's no specific architecture >> > depends for DW_APB_ICTL and there probably shouldn't be. >> >> Care to see how that driver is selected? Certainly not by x86. > make LLVM=3D1 ARCH=3Di386 allmodconfig > make LLVM=3D1 ARCH=3Di386 -j 31 How does that select the config symbol? Makefile: obj-$(CONFIG_DW_APB_ICTL) +=3D irq-dw-apb-ictl.o Kconfig: config DW_APB_ICTL bool select GENERIC_IRQ_CHIP select IRQ_DOMAIN_HIERARCHY # git grep DW_APB_ICTL arch/arc/plat-axs10x/Kconfig: select DW_APB_ICTL arch/arm/mach-berlin/Kconfig: select DW_APB_ICTL arch/arm/mach-hisi/Kconfig: select DW_APB_ICTL arch/arm64/Kconfig.platforms: select DW_APB_ICTL arch/csky/Kconfig.platforms: select DW_APB_ICTL i386 definitely does not select it. # grep DW_APB_ICTL ../build-386/.config #