public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Yuriy Padlyak <yuriypadlyak@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Fix speaker silence after S3 resume on Xiaomi Mi Laptop Pro 15
Date: Thu, 30 Apr 2026 15:26:35 +0200	[thread overview]
Message-ID: <87zf2kmvec.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260429220903.14918-1-yuriypadlyak@gmail.com>

On Thu, 30 Apr 2026 00:09:03 +0200,
Yuriy Padlyak wrote:
> 
> The Xiaomi Mi Laptop Pro 15 (TM1905, subsystem 1d72:1905) ships with the
> Realtek ALC256 codec on Intel Comet Lake PCH-LP. After S3 resume the
> codec sets coefficient register 0x10 to 0x0220 instead of 0x0020 ― bit 9
> is erroneously set, which silences the internal speaker. Bluetooth and
> HDMI audio are unaffected because they use different paths.
> 
> This is the same mechanism fixed for Clevo NJ51CU by commit edca7cc4b0ac
> ("ALSA: hda/realtek: Fix quirk for Clevo NJ51CU"), but the existing
> ALC256_FIXUP_MIC_NO_PRESENCE_AND_RESUME also reconfigures pin 0x19 as a
> front mic, which is wrong for this Xiaomi where pin 0x19 default is
> 0x411111f0 (disabled). Add a minimal fixup that only clears the stuck
> coef bit, and add the Xiaomi SSID to the quirk table.
> 
> Verified by reading coef 0x10 with hda-verb after resume (returns
> 0x0220), writing 0x0020, and confirming the internal speaker resumes
> output. With this fixup applied the bit is cleared on every codec init,
> including post-resume.
> 
> Signed-off-by: Yuriy Padlyak <yuriypadlyak@gmail.com>
> Cc: <stable@vger.kernel.org>
> Tested-by: Yuriy Padlyak <yuriypadlyak@gmail.com>

Thanks, applied now.


Takashi

      reply	other threads:[~2026-04-30 13:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 22:09 [PATCH] ALSA: hda/realtek: Fix speaker silence after S3 resume on Xiaomi Mi Laptop Pro 15 Yuriy Padlyak
2026-04-30 13:26 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zf2kmvec.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=yuriypadlyak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox