Re: [PATCH] ALSA: hda: intel-dsp-config: Force legacy HDA on Lenovo ThinkPad X1 Yoga Gen 5

[Takashi Iwai <tiwai@suse.de>]

On Sat, 04 Apr 2026 16:47:43 +0200,
Antti Jalomäki wrote:
> 
> The SOF driver fails to initialize on the Lenovo ThinkPad X1 Yoga Gen 5
> with Intel Comet Lake PCH-LP cAVS [8086:02c8]. Add a DMI quirk to force
> legacy HDA driver selection for this device.
> 
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1120554
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=2455066
> Signed-off-by: Antti Jalomäki <antti@nevaberry.com>

Have you tested with the latest kernel together with the latest
SOF-firmware?  Just to be sure, as your reports above didn't indicate
it, and ....

> ---
>  sound/hda/core/intel-dsp-config.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/sound/hda/core/intel-dsp-config.c b/sound/hda/core/intel-dsp-config.c
> index f0a44fd11..179fe4d59 100644
> --- a/sound/hda/core/intel-dsp-config.c
> +++ b/sound/hda/core/intel-dsp-config.c
> @@ -269,6 +269,21 @@ static const struct config_entry config_table[] = {
>  		.device = PCI_DEVICE_ID_INTEL_HDA_CML_LP,
>  		.codec_hid =  &essx_83x6,
>  	},
> +	{
> +		.flags = 0,

... there is no other quirk entries setting like this.  It already
looks very special, and such a case is often due to other problems.


thanks,

Takashi

> +		.device = PCI_DEVICE_ID_INTEL_HDA_CML_LP,
> +		.dmi_table = (const struct dmi_system_id []) {
> +			{
> +				.ident = "Lenovo ThinkPad X1 Yoga Gen 5",
> +				.matches = {
> +					DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +					DMI_MATCH(DMI_PRODUCT_FAMILY,
> +						  "ThinkPad X1 Yoga Gen 5"),
> +				},
> +			},
> +			{}
> +		}
> +	},
>  	{
>  		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
>  		.device = PCI_DEVICE_ID_INTEL_HDA_CML_LP,
> 
> base-commit: 9f2a23bd5d30dc0968e56a2b6e5edb58aff1bc6d
> -- 
> 2.53.0
>