From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A6D1DFFD for ; Tue, 31 Mar 2026 13:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774963487; cv=none; b=FWmOgU79xlSExxH0sjIJjsPgSEGUqiQ0W4Xol4HSP4cxzTAeNErBsu8kZFpLK1HHFqdzFavMRRqPnu3RhEC7ZlgfRWevNu6IGreTLdKljLFAoJTSvmOd6vnlZ/KXpyzQCtv/LwzocLQlaxjsZOYPgVywZAeVdYQ/6JhGdWwYn+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774963487; c=relaxed/simple; bh=jL+JoDSpew4+YzkkW3Z4c7kr1w3hKjtDKCzbzcDZNFk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=PepsNrHOnf1IsfNOoUbZW3vHB7y718u7IDFQvuHGKehfA4zCp0nR89fLg5HxGLcs09Sq7oZEoyu0FREoDH2VcoDkAi4LJ093X/LIqhHoXQlr//yAgBHYdo8Gvv3JMOhwf6weg3k7qDG5tI+fW2xmtAUC+FaC4S+XECusLevWUSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=J9lbY+W8; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="J9lbY+W8" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 3CDBF1A30BD; Tue, 31 Mar 2026 13:24:44 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0D85E6029D; Tue, 31 Mar 2026 13:24:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B317610450244; Tue, 31 Mar 2026 15:24:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774963483; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=E7Ob140Dq6HTtkbqjecnEQ6w1/azojyDrJ3ReUV8Pq8=; b=J9lbY+W8iiXqQLgBspSvxztaUefqdvpIcz6/RM2ykqNthSKO4TBI1cvuu8kK/z+WwMELrr htDSvvrheHtOnshkIolBb/ftSRQ6oiXVd82jLTHqo4G2nwex1hD91rdiwCcT2J/LL0BgX8 ShX1hKuWtgsKPevj6baPfeyR2SVFyf48SZxe1yRg7j15VwBhqBEwrmwTY27RLJrfq4Woy8 DYQH/TLrZNchzhGQkKq9YdRa09qRcB8lyVlh4ZV5WOLT4vePzuITEpu5b2xm3fpsVVyAZj x7yrpuxdP6h+nRUErHkNFDv7aaDw5if7l9DmxFUlMyWe1wPGXMekQ5tauZmWww== From: Miquel Raynal To: Gabor Juhos Cc: Vinod Koul , Neil Armstrong , Igal Liberman , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH phy-fixes] phy: marvell: mvebu-a3700-utmi: fix incorrect USB2_PHY_CTRL register access In-Reply-To: <20260321-a3700-utmi-fix-usb2_phy_ctrl-access-v1-1-6005ff4b5058@gmail.com> (Gabor Juhos's message of "Sat, 21 Mar 2026 15:42:32 +0100") References: <20260321-a3700-utmi-fix-usb2_phy_ctrl-access-v1-1-6005ff4b5058@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 31 Mar 2026 15:24:40 +0200 Message-ID: <87zf3o873b.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Gabor, On 21/03/2026 at 15:42:32 +01, Gabor Juhos wrote: > The mvebu_a3700_utmi_phy_power_off() function tries to modify the > USB2_PHY_CTRL register by using the IO address of the PHY IP block along > with the readl/writel IO accessors. However, the register exist in the > USB miscellaneous register space, and as such it must be accessed via > regmap like it is done in the mvebu_a3700_utmi_phy_power_on() function. > > Change the code to use regmap_update_bits() for mod=C3=ADfying the regist= er Spurious accent here :-) ^ Do you imply that the register access was not working? Or that it was not using the correct API? (hence potential issues with locking might arise) Reviewed-by: Miquel Raynal Miqu=C3=A8l