From: Takashi Iwai <tiwai@suse.de>
To: Rosen Penev <rosenp@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: use kzalloc_flex
Date: Sat, 14 Mar 2026 14:29:23 +0100 [thread overview]
Message-ID: <87zf4aa6a4.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAKxU2N_YN+0k+EjLFvm+vHEwduGB2jn0A+t-4C-GH_MXmWHcKQ@mail.gmail.com>
On Fri, 13 Mar 2026 23:02:08 +0100,
Rosen Penev wrote:
>
> On Wed, Mar 11, 2026 at 11:45 PM Rosen Penev <rosenp@gmail.com> wrote:
> >
> > On Wed, Mar 11, 2026 at 11:34 PM Takashi Iwai <tiwai@suse.de> wrote:
> > >
> > > On Thu, 12 Mar 2026 00:27:48 +0100,
> > > Rosen Penev wrote:
> > > >
> > > > Saves one allocation by using a flexible array member.
> > >
> > > As it's a fixed size array, it doesn't have to be a flex array at all,
> > > so it can be even simpler.
> > That's true. The comment even admits as such. Wonder why it was ever a
> > pointer allocated with calloc...
> Oh no I see the issue:
>
> sound/usb/mixer.c:#define MAX_ID_ELEMS 256
>
> I don't think this is supposed to be in the header.
Why?
Takashi
prev parent reply other threads:[~2026-03-14 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 23:27 [PATCH] ALSA: usb-audio: use kzalloc_flex Rosen Penev
2026-03-12 6:34 ` Takashi Iwai
2026-03-12 6:45 ` Rosen Penev
2026-03-13 22:02 ` Rosen Penev
2026-03-14 13:29 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf4aa6a4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rosenp@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox