The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Kumar, Kaushlendra" <kaushlendra.kumar@intel.com>,
	"peterz@infradead.org" <peterz@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] smpboot: Add NULL check before kthread_unpark()
Date: Fri, 12 Dec 2025 10:10:19 +0900	[thread overview]
Message-ID: <87zf7oec90.ffs@tglx> (raw)
In-Reply-To: <LV3PR11MB8768DB939A646E82EDDE0D4CF5A0A@LV3PR11MB8768.namprd11.prod.outlook.com>

On Wed, Dec 10 2025 at 08:21, Kaushlendra Kumar wrote:
> On Mon, Nov 24 2025, Thomas Gleixner wrote:
>> On Mon, Nov 24 2025 at 10:41, Kaushlendra Kumar wrote:
>>> Add NULL check for tsk before calling kthread_unpark() in
>>> smpboot_unpark_thread() to prevent potential null pointer dereference.
>>
>> How is that ever going to be NULL?
> Thanks for the review.
> Here I was only concerned about edge cases during CPU hotplug state transitions.

Then describe your concern and the edge cases in detail.

Thanks,

        tglx

      reply	other threads:[~2025-12-12  1:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24  5:11 [PATCH] smpboot: Add NULL check before kthread_unpark() Kaushlendra Kumar
2025-12-10  6:50 ` Thomas Gleixner
2025-12-10  8:21   ` Kumar, Kaushlendra
2025-12-12  1:10     ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zf7oec90.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=kaushlendra.kumar@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox