Re: [patch V3 07/20] cpumask: Introduce cpumask_weighted_or()

Thomas Gleixner
2025-11-03T13:30:01Z

On Mon, Nov 03 2025 at 14:45, Shrikanth Hegde wrote:
> On 10/29/25 6:39 PM, Thomas Gleixner wrote:
>> +static __always_inline
>> +unsigned int cpumask_weighted_or(struct cpumask *dstp, const struct cpumask *src1p,
>> + const struct cpumask *src2p)
>> +{
>> + return bitmap_weighted_or(cpumask_bits(dstp), cpumask_bits(src1p),
>> + cpumask_bits(src2p), small_cpumask_bits);
>> +}
>
> nit:
>
> We have currently cpumask_weight_and & variants.
> Wouldn't it be better to name it cpumask_weight_or ?

No. cpumask_weight_and() does weight(mask1 & mask2) but this does

mask3 = mask1 | mask2;
weight(mask3);

That's two very different things.