From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD6521DE2AD
	for <linux-kernel@vger.kernel.org>; Thu, 16 Jan 2025 13:21:16 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1737033678; cv=none; b=eYXyG/3eQfpP63TpHUtW4Vk2k9PMZyCMS5P1nMU4idzixxt5Ltx6SayZ8aHG1yVrbIzubwWDHYwTuHZdp95GzgPbF+qLnwpiwDMV1m10mVS5M0LBZi82MyBpwB+14Bg8uHmLWSVdqrXtuTBlZwOnPwkX6lRkVTnm6RN0Qo0fyME=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1737033678; c=relaxed/simple;
	bh=MGSLA64tDxMHPexdfBbUVukhUTtJOBL/q8qgxaViZQE=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=JXlUOXN7c1uLZRAncereGxkQpENwrpD0OlLndkP6m6xblR0aX7iovHYx3Sf3//zoKp80FUvOCci2HboPnpkIsi3VFyL4jtxTJYg9BnyDL+USFpXyl74m01ZF/saGhMw51PlAaX2IYJ0+97W31utsQzVV/UWrN9EvSSul3zqHdxY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=H1kq5pOo; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=bppmrYOI; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="H1kq5pOo";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="bppmrYOI"
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1737033674;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9Xqne5kKhJtXx1aN4Lg1Tv/KpapNRBQNMtttbnbTfRE=;
	b=H1kq5pOoZG0VpQGLRYj8SGp6YqfvCi7XlU4prpgadv0STqBZ1QGUlvP+UhIESsEDLaepqM
	+Tvn44Ghr0zeK4HMx2pxZ5BxY+lcLPQb1dEemdkJV9jud7JlmaHOaDeCbRAfChfj3XX8zT
	dKUUHqs2wGvP82M4/OY9a+zZAYmnNjbgaFo8BGWXwB92O4OvVlRSPfAxzw5Ydhton1WyE9
	YYeNT9pLFpRAayjV7LZxZ5eLA22yozTC6BePCdbjGCP3fjhz47jSFxF868xlGE28Pp4Tek
	C71RfU4kjxcRTXaxUMssRr2NtQ7RyMMj64zWYpA/UmGXb5nF2VODfq24AJNhEg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1737033674;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9Xqne5kKhJtXx1aN4Lg1Tv/KpapNRBQNMtttbnbTfRE=;
	b=bppmrYOIFQd8yDC1qlg4LLYXrzADs782fPp3Hvhpu2fDy3zeVZ3byO73yFnf3Xomqt+Ymk
	8dFlCDE58Ii2LSAA==
To: Koichiro Den <koichiro.den@canonical.com>, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org
Subject: Re: [PATCH] cpu/hotplug: disallow writing any state in atomic AP
 section to sysfs target
In-Reply-To: <20241220141538.4018232-1-koichiro.den@canonical.com>
References: <20241220141538.4018232-1-koichiro.den@canonical.com>
Date: Thu, 16 Jan 2025 14:21:14 +0100
Message-ID: <87zfjqao8l.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Fri, Dec 20 2024 at 23:15, Koichiro Den wrote:
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 34f1a09349fc..c877443f5888 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -2127,6 +2127,7 @@ static struct cpuhp_step cpuhp_hp_states[] = {
>  	[CPUHP_BP_KICK_AP] = {
>  		.name			= "cpu:kick_ap",
>  		.startup.single		= cpuhp_kick_ap_alive,
> +		.cant_stop		= true,

Why? If it stops here, then no harm is done. The AP just waits for being
released. It won't change the state as that's a seperate handshake
mechanism.

>  	},
>  
>  	/*
> @@ -2192,6 +2193,7 @@ static struct cpuhp_step cpuhp_hp_states[] = {
>  	 * state for synchronsization */
>  	[CPUHP_AP_ONLINE] = {
>  		.name			= "ap:online",
> +		.cant_stop		= true,

Your change log is pretty unclear about the reason for this change.

Thanks,

        tglx