Re: [PATCH 1/1] x86/ioremap: Use is_vmalloc_addr in iounmap

Max R
2024-08-12T12:10:18Z

> So this lacks a Fixes tag and some deep analysis of similar potential
> problems. While at it please use func() notation for functions. In the
> middle of a sentence iounmap does not immediately stand out, but
> iounmap() does. It's documented ...

Yep, will do, not sure which commit to attribute to Fixes though. Probably:

41e94a851304 add devm_memremap_pages

As it seems to be the first one that might cause high_memory to overlap
with VMALLOC.

> The correct helper to use is is_ioremap_addr, as in the generic
> iounmap implementation. This won't matter for x86 currently, but
> it clearly documents what the code is doing.

And will update that too. The patch is over a year old, and at the time of
submission the generic implementation used is_vmalloc_addr.

Best regards,
Max