From: Thomas Gleixner <tglx@linutronix.de>
To: WangYuli <wangyuli@uniontech.com>,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com, wangyuli@uniontech.com, seanjc@google.com,
xiangzelong@uniontech.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, wubo@uniontech.com,
guanwentao@uniontech.com, baimingcong@uniontech.com,
linux-sgx@vger.kernel.org, jarkko@kernel.org,
haitao.huang@linux.intel.com, Kai Huang <kai.huang@intel.com>
Subject: Re: [PATCH v2] x86/cpu: Adjust the error message when BIOS does not support SGX
Date: Wed, 31 Jul 2024 21:49:25 +0200 [thread overview]
Message-ID: <87zfpx4a0q.ffs@tglx> (raw)
In-Reply-To: <D3C34BA892161BCF+20240731153056.303909-1-wangyuli@uniontech.com>
On Wed, Jul 31 2024 at 23:30, wangyuli@uniontech.com wrote:
> When SGX is not supported by the BIOS, the kernel log still output
> the error 'SGX disabled by BIOS', which can be confusing since
> there might not be an SGX-related option in the BIOS settings.
>
> As a kernel, it's difficult to distinguish between the BIOS not
> supporting SGX and the BIOS supporting SGX but it's disabled.
>
> Therefore, update the error message to
> 'SGX disabled or unsupported by BIOS' to make it easier for those
> reading kernel logs to understand what's happening.
>
> Reported-by: Bo Wu <wubo@uniontech.com>
> Link: https://github.com/linuxdeepin/developer-center/issues/10032
> Reviewed-by: Kai Huang <kai.huang@intel.com>
> Link: https://lore.kernel.org/all/a30f7700c7817b3e7e2f2bdb37d5c10a318b2c3b.camel@intel.com/
> Signed-off-by: Zelong Xiang <xiangzelong@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
This Signed-off-by chain is invalid. See:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
Thanks,
tglx
prev parent reply other threads:[~2024-07-31 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 15:30 [PATCH v2] x86/cpu: Adjust the error message when BIOS does not support SGX WangYuli
2024-07-31 19:49 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfpx4a0q.ffs@tglx \
--to=tglx@linutronix.de \
--cc=baimingcong@uniontech.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=guanwentao@uniontech.com \
--cc=haitao.huang@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=wangyuli@uniontech.com \
--cc=wubo@uniontech.com \
--cc=x86@kernel.org \
--cc=xiangzelong@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox