From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCC531CFA9; Sun, 28 Jul 2024 09:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722158575; cv=none; b=AYpmHL+vwnLBbv3xtVP3ENktLS1KxL5S5lTgUCwb6Xqcp427bZQSZbNTMFr2Pg9KuiHJXuZb5sEDcDR+RBm8kQcBOUVPYsrzveo+wxnZG6cPYER43pSb/ELGV7LHo0L2Ook9eCg2IPZNF9Al55YVOZCivMVTtoBQyDAzWTk+m6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722158575; c=relaxed/simple; bh=FgU7FBJsu3CA2q0gEsB+H8HSbPtAsX5dLkzDj863OPQ=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=FUoMYPWnqDI7B7y9EYJDyHpyJJhn/sedyeFpKe9MZFzyJLK54wcwvNBJ4Zy1fHbXgGORbeyRoM2Iuzo/5qOplV/nfhY9AoIGv9MJh7ZyA3x6eoL3RMqHPH11ZIo6CzJNORjIL3IJ+Ow9hedB6vslt4ytSdLr37Fh0KgRQb5ab1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GGpqabrT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GGpqabrT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44BEAC4AF0E; Sun, 28 Jul 2024 09:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722158575; bh=FgU7FBJsu3CA2q0gEsB+H8HSbPtAsX5dLkzDj863OPQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GGpqabrTtXjEWgKAHJfefGPE9MVm8cKKxafXlRJhDfxk/a3etchQaVHou5R0uSEaX zEUOpaxUGBPDSBCC5bYKchuZxurG8+n8Igs50mahBPvt9nOTsk1IQZIuIPkcrawUW8 6DRsxtvOQwKM+LfNsrAP3SJ+GmzS5f7Yf+29T4IMVIGF2KNDJi7DZVnQ3GgX0zCywr PVebCj55yPxVyjdy+UdKAACcdoJzJUhzKvnGiqAZml/tE8clsO3mq/ERjfeF+yZckX ZHljbJZz8PRZA8TZ7u68Y8QunEpEULel/YdbTH0Hf0OfZBHQAWy5+Xq3KHGUQpmeFa znoS+UfCl08Gw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sY07A-00G2Rl-Ou; Sun, 28 Jul 2024 10:22:52 +0100 Date: Sun, 28 Jul 2024 10:22:53 +0100 Message-ID: <87zfq150r6.wl-maz@kernel.org> From: Marc Zyngier To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, James Morse , Gavin Shan , Miguel Luis , Russell King , Jonathan Cameron , Catalin Marinas , tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH AUTOSEL 6.10 14/16] irqchip/gic-v3: Don't return errors from gic_acpi_match_gicc() In-Reply-To: <20240728004739.1698541-14-sashal@kernel.org> References: <20240728004739.1698541-1-sashal@kernel.org> <20240728004739.1698541-14-sashal@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sashal@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, james.morse@arm.com, gshan@redhat.com, miguel.luis@oracle.com, rmk+kernel@armlinux.org.uk, Jonathan.Cameron@huawei.com, catalin.marinas@arm.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sun, 28 Jul 2024 01:47:31 +0100, Sasha Levin wrote: > > From: James Morse > > [ Upstream commit fa2dabe57220e6af78ed7a2f7016bf250a618204 ] > > gic_acpi_match_gicc() is only called via gic_acpi_count_gicr_regions(). > It should only count the number of enabled redistributors, but it > also tries to sanity check the GICC entry, currently returning an > error if the Enabled bit is set, but the gicr_base_address is zero. > > Adding support for the online-capable bit to the sanity check will > complicate it, for no benefit. The existing check implicitly depends on > gic_acpi_count_gicr_regions() previous failing to find any GICR regions > (as it is valid to have gicr_base_address of zero if the redistributors > are described via a GICR entry). > > Instead of complicating the check, remove it. Failures that happen at > this point cause the irqchip not to register, meaning no irqs can be > requested. The kernel grinds to a panic() pretty quickly. > > Without the check, MADT tables that exhibit this problem are still > caught by gic_populate_rdist(), which helpfully also prints what went > wrong: > | CPU4: mpidr 100 has no re-distributor! > > Signed-off-by: James Morse > Reviewed-by: Gavin Shan > Tested-by: Miguel Luis > Signed-off-by: Russell King (Oracle) > Reviewed-by: Jonathan Cameron > Signed-off-by: Jonathan Cameron > Reviewed-by: Marc Zyngier > Link: https://lore.kernel.org/r/20240529133446.28446-14-Jonathan.Cameron@huawei.com > Signed-off-by: Catalin Marinas > Signed-off-by: Sasha Levin Please drop this. It has no purpose being backported to stable. Thanks, M. -- Without deviation from the norm, progress is not possible.