Re: [PATCH v1] ALSA: memalloc: Fix indefinite hang in non-iommu case

Takashi Iwai
2024-02-19T11:19:58Z

On Fri, 16 Feb 2024 17:22:45 +0100,
Sven van Ashbrook wrote:
>
> On Fri, Feb 16, 2024 at 9:43 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > OK, then how about the one like below?
> >
> > This changes:
> > - Back to __GFP_NORETRY as default
> > - Use __GFP_RETRY_MAYFAIL for SNDRV_DMA_TYPE_NONCONTIG with IOMMU;
> > this should cover the commit a61c7d88d38c
> > - Also use __GFP_RETRY_MAYFAIL for the SG-fallback allocations of the
> > minimal order, just like IOMMU allocator does.
> >
> > This should be less destructive, while still allowing more aggressive
> > allocations for SG buffers.
>
> This one looks like it would keep the SOF firmware allocation issue at bay,
> in both iommu and non-iommu cases.
>
> If there is no further discussion in this thread, we'll stress test this
> on iommu and non-iommu Chromebooks.

The test with my latest patch would be appreciated in anyway.

thanks,

Takashi