From: Takashi Iwai <tiwai@suse.de>
To: Stefan Binding <sbinding@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH v2 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands
Date: Mon, 20 Nov 2023 12:37:33 +0100 [thread overview]
Message-ID: <87zfz8psea.wl-tiwai@suse.de> (raw)
In-Reply-To: <20231117163609.823627-1-sbinding@opensource.cirrus.com>
On Fri, 17 Nov 2023 17:36:07 +0100,
Stefan Binding wrote:
>
> Some systems use older firmware which does not support newer commands
> which are used to enable external boost. For those systems, we can
> workaround this by writing the registers directly.
>
> We can use the firmware version, stored inside cs_dsp, to determine
> whether or not the command is supported.
> To achieve this, it requires a cleanup in the api, to pass the cs_dsp
> struct into the function.
>
> We can also remove the redundant boolean firmware_running from the HDA
> driver, and use the equivalent state inside cs_dsp.
>
> Changes since V1:
> - Added fixes tag to all patches
> - patches rebased after v6.7 release
>
> Stefan Binding (2):
> ALSA: hda: cs35l41: Remove unnecessary boolean state variable
> firmware_running
> ALSA: cs35l41: Fix for old systems which do not support command
Both patches applied now. Thanks.
Takashi
prev parent reply other threads:[~2023-11-20 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 16:36 [PATCH v2 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands Stefan Binding
2023-11-17 16:36 ` [PATCH v2 1/2] ALSA: hda: cs35l41: Remove unnecessary boolean state variable firmware_running Stefan Binding
2023-11-17 16:36 ` [PATCH v2 2/2] ALSA: cs35l41: Fix for old systems which do not support command Stefan Binding
2023-11-20 11:37 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfz8psea.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox